At 09:44 PM 4/22/98 +0400, Kirill M. Katsnelson wrote:
I have built with Andy's fixes. Coolbars!
Attached is a patch with small fixes. Andy, if you compiled with higher
warning level, you'd caught one of these yourself. There is a bunch
of unprototyped function references also.
Some notes. First, buttons are small, and places asymmetrically in height,
so there is about 10 pixels of gray between buttons and the first line of
text (see the attached picture).
Second, there is one pixel gap at the right and bottom edges.
Next, you reposition toolbars on grame redisplay. This is not very
good, because if a frame got shrunk, redisplay does not occur, so right
toolbar egde changes its shape. Although, sizing the toolbar so it is
wider at least 2 pixels than the frame will solve this problem.
Then, the toolbar is wrappable. When window shrinks, the toolbars
wraps, and top pieces of second row buttons show up in that unused
gray space.
Finally, toolbar gets redrawn on every mouse motion when sizing the frame.
If Andy won't object, I would patch last 4 of 5 issues.
If you know how to fix them - go ahead with my blessing. I've bashed my
head against Win32 for long enough at the moment.
The warning level is bugging me, I turned off stuff for cygwin because of
the number of X warnings. Now I will turn it back on and fix my install of X.
There is also 1 potential bug with tooltips that I know of.
andy