8:55 p.m.
This bug report will be sent to the XEmacs Development Team,
not to your local site managers!!
Please write in English, because the XEmacs maintainers do not have
translators to read other languages for them.
In XEmacs 21.2 (beta36) "Notus" [Lucid] (sparc-sun-solaris2.7, Mule) of Thu Nov
2 2000 on edgedsp5
configured using `configure --compiler=cc '--cflags=-g -xO4' --verbose
--extra-verbose --with-cde --with-dragndrop --with-mule --with-pop
--package-path=/apps/public/XEmacs/lib --prefix=/apps/public/XEmacs/21.2
--bindir=/apps/public/XEmacs/21.2/bin/solaris2.7 --with-workshop --with-dialogs=motif
'--site-includes=/apps/public/solaris2.7/usr/openwin/include
/apps/public/solaris2.7/include'
'--site-libraries=/apps/public/solaris2.7/usr/openwin/lib
/apps/public/solaris2.7/lib''
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
I had just done 'C-x C-h C-u M-| gindent" to have GNU indent indent my
buffer and replace the buffer with the output of indent.
The progress bar popped up and I have to wiggle the mouse to actually
get the progress bar to move at a reasonable speed (other it just
seems to hang for a very long time). (Another bug, I think. Does
this happen for anyone else?)
After the progress bar went away, XEmacs decided to GC, the GC cursor
popped up, and boom.
Here is the C traceback. Perhaps not that useful because optimization
was used, but here it is anyway.
Could there be a GC bug in file_truename or some process I/O stuff?
Lately, whenever I get a crash in GC, it seems to be always just after
I've tried to do some kind of I/O like saving the file or auto-saving
the file. How do I go about tracking this down? Since it's
intermittent, I think doing a GC after every command (or whatever that
option is) will take a long time.
Ray
[1] _kill(0x0, 0xb, 0x0, 0x0, 0xfebb1f98, 0xa0020), at 0xfeb96870
=>[2] fatal_error_signal(sig = ???) (optimized), at 0xa0020 (line ~479) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/emacs.c"
[3] sigacthandler(0xb, 0x0, 0xffbe92a0, 0x302804, 0x1f, 0x3a5800), at 0xfeb95988
---- called from signal handler with signal 11 (SIGSEGV) ------
[4] mark_object(obj = ???) (optimized), at 0x699b4 (line ~2462) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/alloc.c"
[5] garbage_collect_1() (optimized), at 0x6b314 (line ~3311) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/alloc.c"
[6] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9644 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[7] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[8] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[9] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[10] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[11] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[12] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[13] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[14] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[15] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[16] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[17] call2_check_string(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0x10ef8c (line
~367) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[18] Ffile_truename(filename = ???, default_ = ???) (optimized), at 0x10fd5c (line
~1258) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[19] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa98c8 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[20] Fapply(nargs = ???, args = ???) (optimized), at 0xaa038 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[21] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[22] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[23] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[24] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[25] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[26] call2_check_string(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0x10ef8c (line
~367) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[27] Ffile_truename(filename = ???, default_ = ???) (optimized), at 0x10fd5c (line
~1258) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[28] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa98c8 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[29] Fapply(nargs = ???, args = ???) (optimized), at 0xaa038 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[30] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[31] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[32] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[33] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[34] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[35] call2_check_string(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0x10ef8c (line
~367) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[36] Ffile_truename(filename = ???, default_ = ???) (optimized), at 0x10fd5c (line
~1258) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[37] Fget_file_buffer(filename = ???) (optimized), at 0x6d5a0 (line ~441) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/buffer.c"
[38] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa98b4 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[39] Fapply(nargs = ???, args = ???) (optimized), at 0xaa038 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[40] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[41] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[42] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[43] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[44] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[45] Fget_file_buffer(filename = ???) (optimized), at 0x6d510 (line ~441) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/buffer.c"
[46] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa98b4 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[47] Fapply(nargs = ???, args = ???) (optimized), at 0xaa038 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[48] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[49] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[50] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[51] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[52] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[53] Fget_file_buffer(filename = ???) (optimized), at 0x6d510 (line ~441) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/buffer.c"
[54] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa98b4 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[55] Fapply(nargs = ???, args = ???) (optimized), at 0xaa038 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[56] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[57] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[58] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[59] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[60] call2(fn = ???, arg0 = ???, arg1 = ???) (optimized), at 0xaad48 (line ~4190) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[61] Fget_file_buffer(filename = ???) (optimized), at 0x6d510 (line ~441) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/buffer.c"
[62] get_truename_buffer(filename = ???) (optimized), at 0x6d96c (line ~538) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/buffer.c"
[63] lock_file(fn = ???) (optimized), at 0xb71cc (line ~303) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/filelock.c"
[64] Fwrite_region_internal(start = ???, end = ???, filename = ???, append = ???, visit
= ???, lockname = ???, codesys = ???) (optimized), at 0x1132c8 (line ~3123) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[65] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa996c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[66] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[67] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[68] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[69] Fapply(nargs = ???, args = ???) (optimized), at 0xaa1e4 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[70] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[71] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[72] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[73] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[74] call8(fn = ???, arg0 = ???, arg1 = ???, arg2 = ???, arg3 = ???, arg4 = ???, arg5 =
???, arg6 = ???, arg7 = ???) (optimized), at 0xaafac (line ~4305) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[75] Fwrite_region_internal(start = ???, end = ???, filename = ???, append = ???, visit
= ???, lockname = ???, codesys = ???) (optimized), at 0x113148 (line ~3123) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[76] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa996c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[77] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[78] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[79] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[80] Fapply(nargs = ???, args = ???) (optimized), at 0xaa1e4 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[81] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[82] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[83] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[84] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[85] call8(fn = ???, arg0 = ???, arg1 = ???, arg2 = ???, arg3 = ???, arg4 = ???, arg5 =
???, arg6 = ???, arg7 = ???) (optimized), at 0xaafac (line ~4305) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[86] Fwrite_region_internal(start = ???, end = ???, filename = ???, append = ???, visit
= ???, lockname = ???, codesys = ???) (optimized), at 0x113148 (line ~3123) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[87] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa996c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[88] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[89] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[90] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[91] Fapply(nargs = ???, args = ???) (optimized), at 0xaa1e4 (line ~3731) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[92] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa99c0 (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[93] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[94] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[95] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa9a0c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[96] call8(fn = ???, arg0 = ???, arg1 = ???, arg2 = ???, arg3 = ???, arg4 = ???, arg5 =
???, arg6 = ???, arg7 = ???) (optimized), at 0xaafac (line ~4305) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[97] Fwrite_region_internal(start = ???, end = ???, filename = ???, append = ???, visit
= ???, lockname = ???, codesys = ???) (optimized), at 0x113148 (line ~3123) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/fileio.c"
[98] Ffuncall(nargs = ???, args = ???) (optimized), at 0xa996c (line ~3466) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/eval.c"
[99] execute_optimized_program(program = ???, stack_depth = ???, constants_data = ???)
(optimized), at 0x769a8 (line ~601) in
"/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
[100] funcall_compiled_function(fun = ???, nargs = ???, args = ???) (optimized), at
0x7624c (line ~472) in "/apps/public/XEmacs/src/xemacs-21.2.36/src/bytecode.c"
5:39 a.m.
>>>> "Ray" == Raymond Toy
<toy(a)rtp.ericsson.se> writes:
Ray> Could there be a GC bug in file_truename or some process I/O stuff?
Ray> Lately, whenever I get a crash in GC, it seems to be always just after
Ray> I've tried to do some kind of I/O like saving the file or auto-saving
Ray> the file. How do I go about tracking this down? Since it's
Ray> intermittent, I think doing a GC after every command (or whatever that
Ray> option is) will take a long time.
Yes, always_gc set to 1 slows down XEmacs enormously. But if you have
a likely suspect, then that may be the best way to find a
_reproducible_ crash, at which point it can be dissected, analysed and
maybe even fixed. If you can't reproduce the crash, you never know
whether you've fixed it.
Here's how to do it without waiting an eternity.
Build a debug xemacs, set a breakpoint at your suspect function (here
probably Ffile_truename), run till you hit the breakpoint, then
(gdb) set always_gc=1
(gdb) finish
If you crash here reproducibly, congratulations! you've found it.
If you return to gdb, better luck next time...
Ben did some GC work on these sorts of functions, but I thought that
was only 21.2.
Martin
7:57 a.m.
Raymond Toy <toy(a)rtp.ericsson.se> writes:
Could there be a GC bug in file_truename or some process I/O stuff?
I read some filelock related codes and found one GC bug. I
removed call to compute-buffer-file-name because its return
value is just discarded. If you set it to buffer filename
there, you'll get /full/path/to/.emacs when you find-file
~/.emacs instead of .emacs
2000-11-09 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* fileio.c (Finsert_file_contents_internal): UNGCPRO before return.
Remove unused call to compute-buffer-file-name.
Index: fileio.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/fileio.c,v
retrieving revision 1.51.2.30
diff -u -r1.51.2.30 fileio.c
--- fileio.c 2000/11/06 05:43:29 1.51.2.30
+++ fileio.c 2000/11/09 07:41:36
＠＠ -2680,7 +2680,6 ＠＠
(filename, visit, start, end, replace, codesys, used_codesys))
{
/* This function can call lisp */
- /* #### dmoore - this function hasn't been checked for gc recently */
struct stat st;
int fd;
int saverrno = 0;
＠＠ -2763,9 +2762,10 ＠＠
{
end_multiple_change (buf, mc_count);
- return Fsignal (Qfile_error,
- list2 (build_translated_string("not a regular file"),
- filename));
+ RETURN_UNGCPRO
+ (Fsignal (Qfile_error,
+ list2 (build_translated_string("not a regular file"),
+ filename)));
}
}
#endif /* S_IFREG */
＠＠ -3027,13 +3027,6 ＠＠
{
buf->modtime = st.st_mtime;
buf->filename = filename;
- /* XEmacs addition: */
- /* This function used to be in C, ostensibly so that
- it could be called here. But that's just silly.
- There's no reason C code can't call out to Lisp
- code, and it's a lot cleaner this way. */
- if (!NILP (Ffboundp (Qcompute_buffer_file_truename)))
- call1 (Qcompute_buffer_file_truename, make_buffer (buf));
}
BUF_SAVE_MODIFF (buf) = BUF_MODIFF (buf);
buf->auto_save_modified = BUF_MODIFF (buf);
--
Yoshiki Hayashi
8:53 a.m.
>>>> "Y" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Y> Raymond Toy <toy(a)rtp.ericsson.se> writes:
> Could there be a GC bug in file_truename or some process I/O
stuff?
Y> I read some filelock related codes and found one GC bug. I
Y> removed call to compute-buffer-file-name because its return
Y> value is just discarded. If you set it to buffer filename
Y> there, you'll get /full/path/to/.emacs when you find-file
Y> ~/.emacs instead of .emacs
Perhaps it is supposed to be used to initialize the buffer file
truename, not the buffer file name.
Y> 2000-11-09 Yoshiki Hayashi <yoshiki(a)xemacs.org>
Y> * fileio.c (Finsert_file_contents_internal): UNGCPRO before return.
Y> Remove unused call to compute-buffer-file-name.
Y> - return Fsignal (Qfile_error,
Y> - list2 (build_translated_string("not a regular file"),
Y> - filename));
Y> + RETURN_UNGCPRO
Y> + (Fsignal (Qfile_error,
Y> + list2 (build_translated_string("not a regular file"),
Y> + filename)));
Y> }
I believe this is correct, although this will only cause a problem if
Fsignal actually returns, for example by using `r' from the debugger.
So this is probably not Raymond's problem.
For bonus points: write a program that will find all the places in
the code that a naked return (without RETURN_UNGCPRO) is being called
from within a GCPRO'ed region of code.
Y> - /* XEmacs addition: */
Y> - /* This function used to be in C, ostensibly so that
Y> - it could be called here. But that's just silly.
Y> - There's no reason C code can't call out to Lisp
Y> - code, and it's a lot cleaner this way. */
Y> - if (!NILP (Ffboundp (Qcompute_buffer_file_truename)))
Y> - call1 (Qcompute_buffer_file_truename, make_buffer (buf));
I suggest you do some more thinking here.
Obviously someone intended for the function
compute-buffer-file-truename (in files.el) to be called. Your job is
to figure out WHY. Perhaps the value is to be used, or perhaps
compute-buffer-file-truename is being called for side-effect.
If you were to remove the above code, then the code it called in
files.el should be removed as well. My guess is that it is in lisp so
that the user can easily modify it.
Martin
12:55 a.m.
Martin Buchholz <martin(a)xemacs.org> writes:
For bonus points: write a program that will find all the places in
the code that a naked return (without RETURN_UNGCPRO) is being called
from within a GCPRO'ed region of code.
I added it to my TODO list.
Y> - /* XEmacs addition: */
Y> - /* This function used to be in C, ostensibly so that
Y> - it could be called here. But that's just silly.
Y> - There's no reason C code can't call out to Lisp
Y> - code, and it's a lot cleaner this way. */
Y> - if (!NILP (Ffboundp (Qcompute_buffer_file_truename)))
Y> - call1 (Qcompute_buffer_file_truename, make_buffer (buf));
I suggest you do some more thinking here.
Obviously someone intended for the function
compute-buffer-file-truename (in files.el) to be called. Your job is
to figure out WHY. Perhaps the value is to be used, or perhaps
compute-buffer-file-truename is being called for side-effect.
You're right. How broken. Lisp function is called for
side-effect! I'll leave those code untouched.
--
Yoshiki Hayashi
6:13 p.m.
-- Martin Buchholz <martin(a)xemacs.org> spake thusly:
For bonus points: write a program that will find all the places in
the code that a naked return (without RETURN_UNGCPRO) is being called
from within a GCPRO'ed region of code.
Not sure if this is what you want, but I hacked together a quick Perl script which
probably comes close (although it finds a bunch of stuff in comments as well as bits you
actually care about):
6:21 a.m.
Matt Tucker <tuck(a)whistlingfish.net> writes:
-- Martin Buchholz <martin(a)xemacs.org> spake thusly:
> For bonus points: write a program that will find all the places in
> the code that a naked return (without RETURN_UNGCPRO) is being called
> from within a GCPRO'ed region of code.
Not sure if this is what you want, but I hacked together a
quick Perl script which probably comes close (although it
finds a bunch of stuff in comments as well as bits you
actually care about):
Thanks! Here's the fix.
2000-11-14 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* device-msw.c:
* eldap.c:
* event-Xt.c:
* event-stream.c:
* print.c:
Do UNGCPRO before return.
Index: device-msw.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/device-msw.c,v
retrieving revision 1.20.2.26
diff -u -r1.20.2.26 device-msw.c
--- device-msw.c 2000/09/20 02:38:26 1.20.2.26
+++ device-msw.c 2000/11/14 06:12:44
＠＠ -1019,6 +1019,7 ＠＠
ldm_current->printer_name = xstrdup (ldm_new->printer_name);
}
+ UNGCPRO;
return DEVICE_MSPRINTER_DEVMODE (d);
}
Index: eldap.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/eldap.c,v
retrieving revision 1.13.2.19
diff -u -r1.13.2.19 eldap.c
--- eldap.c 2000/10/31 13:15:17 1.13.2.19
+++ eldap.c 2000/11/14 06:12:47
＠＠ -701,8 +701,6 ＠＠
Lisp_Object values = Qnil;
struct gcpro gcpro1, gcpro2;
- GCPRO2 (current, values);
-
/* Do all the parameter checking */
CHECK_LIVE_LDAP (ldap);
ld = XLDAP (ldap)->ld;
＠＠ -720,6 +718,8 ＠＠
ldap_mods = alloca_array (LDAPMod, len);
ldap_mods_ptrs = alloca_array (LDAPMod *, 1 + len);
i = 0;
+
+ GCPRO2 (current, values);
EXTERNAL_LIST_LOOP (mods, mods)
{
current = XCAR (mods);
Index: event-Xt.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/event-Xt.c,v
retrieving revision 1.41.2.35
diff -u -r1.41.2.35 event-Xt.c
--- event-Xt.c 2000/11/13 08:58:06 1.41.2.35
+++ event-Xt.c 2000/11/14 06:13:04
＠＠ -1350,10 +1350,10 ＠＠
Lisp_Object l_dndlist = Qnil, l_item = Qnil;
struct gcpro gcpro1, gcpro2, gcpro3, gcpro4;
- GCPRO4 (l_type, l_data, l_dndlist, l_item);
-
if (! frame)
return 0; /* not for us */
+
+ GCPRO4 (l_type, l_data, l_dndlist, l_item);
XSETFRAME (emacs_event->channel, frame);
emacs_event->event_type = misc_user_event;
Index: event-stream.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/event-stream.c,v
retrieving revision 1.45.2.36
diff -u -r1.45.2.36 event-stream.c
--- event-stream.c 2000/11/13 09:00:31 1.45.2.36
+++ event-stream.c 2000/11/14 06:13:24
＠＠ -3372,7 +3372,7 ＠＠
{
Vrecent_keys_ring = make_vector (recent_keys_ring_size, Qnil);
/* And return nothing in particular. */
- return make_vector (0, Qnil);
+ RETURN_UNGCPRO (make_vector (0, Qnil));
}
if (NILP (XVECTOR_DATA (Vrecent_keys_ring)[recent_keys_ring_index]))
＠＠ -3430,7 +3430,6 ＠＠
Lisp_Object new_vector = Qnil;
int i, j, nkeys, start, min;
struct gcpro gcpro1;
- GCPRO1 (new_vector);
CHECK_INT (size);
if (XINT (size) <= 0)
＠＠ -3438,12 +3437,13 ＠＠
if (XINT (size) == recent_keys_ring_size)
return size;
+ GCPRO1 (new_vector);
new_vector = make_vector (XINT (size), Qnil);
if (NILP (Vrecent_keys_ring))
{
Vrecent_keys_ring = new_vector;
- return size;
+ RETURN_UNGCPRO (size);
}
if (NILP (XVECTOR_DATA (Vrecent_keys_ring)[recent_keys_ring_index]))
Index: print.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/print.c,v
retrieving revision 1.27.2.25
diff -u -r1.27.2.25 print.c
--- print.c 2000/11/06 05:43:12 1.27.2.25
+++ print.c 2000/11/14 06:14:08
＠＠ -1420,6 +1420,7 ＠＠
write_char_internal ("#", printcharfun);
print_internal (XCDR (tem), printcharfun, escapeflag);
write_char_internal ("#", printcharfun);
+ UNGCPRO;
return;
}
else
--
Yoshiki Hayashi
8577
days inactive
8584
days old
6 comments
4 participants
participants (4)
-
Martin Buchholz -
Matt Tucker -
Raymond Toy -
Yoshiki Hayashi