On 06 May 2002, Ronald Wahl said:
On 07 May 2002 02:34:14 +0900, Stephen J Turnbull wrote:
>>>>>> "Ronald" == Ronald Wahl <rwa(a)peppercon.com>
writes:
Ronald> I encountered a bug with pcl-cvs (v1.60) and the
Ronald> xemacs-21.4.7. Pcl-cvs may not detect modified files
Ronald> during cvs-examine. Sometimes it works but most of the
Ronald> time it doesn't. With xemacs-21.4.6 it seem to work. Are
Ronald> there any fixes for this issue?
> I don't think anything has changed that would affect this.
And I _know_ that there something changed that affect this: ;-)
Oh bugger. Sorry.
(I've still seen no problems with this patch; maybe I'm not adventurous
enough.)
diff --text -u 'xemacs-21.4.6/src/process.h'
'xemacs-21.4.7/src/process.h'
Index: ././src/process.h
--- ././src/process.h Fri Apr 13 03:24:12 2001
+++ ././src/process.h Sat May 4 17:32:06 2002
@@ -45,7 +45,7 @@
#define XSETPROCESS(x, p) XSETRECORD (x, p, process)
#define PROCESSP(x) RECORDP (x, process)
#define CHECK_PROCESS(x) CHECK_RECORD (x, process)
-#define PROCESS_LIVE_P(x) (!NILP ((x)->pipe_instream))
+#define PROCESS_LIVE_P(x) (EQ ((x)->status_symbol, Qrun))
#define CHECK_LIVE_PROCESS(x) do { \
CHECK_PROCESS (x); \
If I reverse-apply this patch to xemacs-21.4.7 it works again.
OK, so code that calls PROCESS_LIVE_P is asking two different questions
in two different places.
In create_process(), read_process_output(), and set_process_filter(),
the question being asked is `can I get data from this subprocess) (what
the original definition said). This may well be possible if the process
has done some output that isn't yet read, and then died.
In delete_process(), kill_buffer_processes(), and process-live-p itself,
the question is `can I send signals to this process' or `is this process
still running in the OS'.
I think we need two #defines; PROCESS_LIVE_P() as defined in 21.4.7, and
PROCESS_INPUTTABLE_P (crap name though).
I'll roll a patch that does that.
Sorry for the inconvenience.
--
`Blueshifters were moving away... Redshifters were moving in...'
--- Justina Robson, _Mappa Mundi_, with startling new
evidence for the gib gnab hypothesis