7:52 p.m.
The following message is a courtesy copy of an article
that has been posted to comp.emacs.xemacs as well.
Hi, for some time now, I have some coding in my ~/.emacs (appended),
which is IMHO quite useful if you work under both Unix and Windows:
button2 on the multibyte extension status in the modeline (ISO8, ISO8:T
etc) toggles the end-of-line type of the current buffer, i.e., toggles
between Unix- (LF) and Dos- (CRLF) line endings.
If this is considered generally useful, I would send corresponding
patches for coding.el and code-files.el. I need some feedback whether
the patches should also include the following patches for command
`toggle-buffer-file-coding-system' which does (or should do) the same:
1. Also toggles eol type for new files (technical: switches from eol
type nil to crlf, of course not for coding systems like binary).
2. Sets buffer as modified (if not read-only). Why do you want to
toggle the eol type if you don't want to save the buffer?
BTW, any possibility to get ":dos" instead of ":T" in the modeline?
- Christoph
(defvar modeline-coding-system-extent (make-extent nil nil)
"Extent covering the %C specification of the string in the modeline.")
(defvar modeline-coding-system-map
(let ((map (make-sparse-keymap)))
(define-key map 'button2 'mouse-toggle-buffer-file-coding-system)
map))
(set-extent-face modeline-coding-system-extent 'modeline-mousable-minor-mode)
(set-extent-property modeline-coding-system-extent 'help-echo
"button2 toggles the buffer's end-of-line type")
(set-extent-keymap modeline-coding-system-extent modeline-coding-system-map)
;; From mule/mule-init.el, now coding.el:
(if (or (featurep 'mule) (featurep 'file-coding))
(let ((modeline (cdr (default-value 'modeline-format)))) ; w/o initial
""
(setq-default modeline-format
(cons ""
(cons (cons modeline-coding-system-extent
'modeline-multibyte-status)
(if (eq (car-safe modeline) ; coding.el
'modeline-multibyte-status)
(cdr modeline)
modeline))))))
(defun mouse-toggle-buffer-file-coding-system (event)
(interactive "e")
(save-excursion
(set-buffer (event-buffer event))
;; Next 9 lines: like `toggle-buffer-file-coding-system', but also toggles
;; if none of the end-of-line variants is the current one (assuming -unix),
;; should be probably part of `toggle-buffer-file-coding-system'
(let ((eol-type
(coding-system-eol-type buffer-file-coding-system)))
(setq buffer-file-coding-system
(subsidiary-coding-system
(coding-system-base buffer-file-coding-system)
(cond ((eq eol-type 'lf) 'crlf)
((eq eol-type 'crlf) 'lf)
((eq eol-type 'cr) 'lf)
(t 'crlf)))))
;; Next line should be part of `toggle-buffer-file-coding-system'
(or buffer-read-only (set-buffer-modified-p t))
(redraw-modeline)))
10:41 a.m.
(comp.emacs.xemacs is removed as I don't have access to net
news here.)
Christoph Wedler <Christoph.Wedler(a)sap.com> writes:
button2 on the multibyte extension status in the modeline (ISO8,
ISO8:T
etc) toggles the end-of-line type of the current buffer, i.e., toggles
between Unix- (LF) and Dos- (CRLF) line endings.
If this is considered generally useful, I would send corresponding
patches for coding.el and code-files.el.
I'm not sure the usefulness as I don't use mouse often.
Probably I'm not the good person to judge this kind of
feature. However, I think it is good for beginners so I'm
for including it in XEmacs.
I need some feedback whether
the patches should also include the following patches for command
`toggle-buffer-file-coding-system' which does (or should do) the same:
1. Also toggles eol type for new files (technical: switches from eol
type nil to crlf, of course not for coding systems like binary).
No, I don't think toggle-buffer-file-coding-system should
change the default EOL type.
2. Sets buffer as modified (if not read-only). Why do you want to
toggle the eol type if you don't want to save the buffer?
I like it. I have long been wanted that
set-buffer-file-coding-system do the same but it didn't
annoyed me enough to submit a patch. :-)
BTW, any possibility to get ":dos" instead of
":T" in the modeline?
I think it is a good change. GNU Emacs prints (DOS) and
(MAC) and it is easier to recognize than cryptic ':T'. (I
don't know how LF is represented. I don't use OS whose
default EOL type is not LF).
When you submit a patch, please submit separate patch for
each feature. If you include all feature in one patch and
if someone disagrees with one feature, then entire patch
won't go in. It also allows us to review the patch with
feature by feature basis.
--
Yoshiki Hayashi
12:21 p.m.
Opinions only, I would not APPROVE or VETO this patch for the
mainline. It won't go in to 21.4, though, not before 21.4 goes
stable.
I have some ideas about dealing with this, but that will have to wait,
probably until January, too.
>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Christoph Wedler <Christoph.Wedler(a)sap.com> writes:
> button2 on the multibyte extension status in the modeline
> (ISO8, ISO8:T etc) toggles the end-of-line type of the current
> buffer, i.e., toggles between Unix- (LF) and Dos- (CRLF) line
> endings.
I don't ever do this kind of thing. OTOH, I can't really think of
many things to do with mouse clicks on that "button". But it can't be
a toggle. It has to cycle through Mac (CR) as well by default. This
could be generalized to cycle through a list contained in a variable,
but I think that's overkill since at worst you double click.
A couple of others: I find the MB status indicator a nuisance, as most
of the time XEmacs does the right thing. With the proliferation of
minor modes, modeline space is at a premium. So a toggle for really
compressed notation vs more verbose would be nice. Alternatively,
tooltips for the verbose explanation.
A smart menu of alternative coding systems compatible with the text
currently in the buffer.
> 1. Also toggles eol type for new files (technical: switches
> from eol type nil to crlf, of course not for coding systems
> like binary).
Yoshiki> No, I don't think toggle-buffer-file-coding-system should
Yoshiki> change the default EOL type.
My feeling, too.
> 2. Sets buffer as modified (if not read-only). Why do you want
> to toggle the eol type if you don't want to save the buffer?
Yoshiki> I like it. I have long been wanted that
Yoshiki> set-buffer-file-coding-system do the same but it didn't
Yoshiki> annoyed me enough to submit a patch. :-)
Andy did that, or something like it. I think this should be consistent.
> BTW, any possibility to get ":dos" instead of
":T" in the
> modeline?
Yoshiki> I think it is a good change.
This depends on whether you care. I rarely do. I want that modeline
space. This really should be configurable.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
5:07 p.m.
At 09:21 PM 12/5/2001 +0900, Stephen J. Turnbull wrote:
>>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Christoph Wedler <Christoph.Wedler(a)sap.com> writes:
>> button2 on the multibyte extension status in the modeline
>> (ISO8, ISO8:T etc) toggles the end-of-line type of the current
>> buffer, i.e., toggles between Unix- (LF) and Dos- (CRLF) line
>> endings.
I don't ever do this kind of thing. OTOH, I can't really think of
many things to do with mouse clicks on that "button". But it can't be
a toggle. It has to cycle through Mac (CR) as well by default. This
could be generalized to cycle through a list contained in a variable,
but I think that's overkill since at worst you double click.
Actually I really like this idea, toggle-buffer-file-coding-system is too
opaque. I think it should either call toggle-buffer-file-coding-system or
it should popup a menu of available EOL things. In a windows world you end
up changing the EOL a lot.
Yoshiki> I think it is a good change.
This depends on whether you care. I rarely do. I want that modeline
space. This really should be configurable.
I tend to agree.
andy
1:26 a.m.
>>>> "Andy" == Andy Piper <andyp(a)bea.com>
writes:
Andy> In a windows world you end up changing the EOL a lot.
Well, that sucks. If you have a suggestion as to how to reduce the
frequency, or even a short description of what kind of situation you
you want to do it, a "guess the right EOL" feature sounds like a good
bite-size task to throw to all those hungry volunteers.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
4:43 a.m.
Andy> In a windows world you end up changing the EOL a lot.
Well, that sucks. If you have a suggestion as to how to reduce the
frequency, or even a short description of what kind of situation you
you want to do it, a "guess the right EOL" feature sounds like a good
bite-size task to throw to all those hungry volunteers.
Actually it probably occurs more under cygwin. In a truly native world the
frequency should be less - but then that's even more reason for the default
to be crlf under native windows.
andy
11:18 a.m.
New subject: [Proposed Patch] button2 on ISO8:T in modeline toggles eol type
Andy Piper <andyp(a)bea.com> writes:
> Yoshiki> I think it is a good change.
>
>This depends on whether you care. I rarely do. I want that modeline
>space. This really should be configurable.
I tend to agree.
I agree that it should be configurable and I usually don't
care about the EOL type of a file. But I think the option
should be between DOS and none. I don't think T and t makes
sense for most people. But perhaps this point is moot
anyway because if you create a variable like
modeline-eol-type or something, it would be easy to
implement all three variants.
--
Yoshiki Hayashi
6:10 p.m.
At 08:18 PM 12/6/01 +0900, Yoshiki Hayashi wrote:
I agree that it should be configurable and I usually don't
care about the EOL type of a file. But I think the option
should be between DOS and none. I don't think T and t makes
sense for most people. But perhaps this point is moot
anyway because if you create a variable like
modeline-eol-type or something, it would be easy to
implement all three variants.
I was agreeing with the modline space thing rather than the DOSvs mac
thing. I think the actually function should do what it does now - i.e.
toggle between dos and unix formats. We should probably improve it to
include mac format only under macos.
andy
5:04 p.m.
At 07:41 PM 12/5/2001 +0900, Yoshiki Hayashi wrote:
> 1. Also toggles eol type for new files (technical: switches
from eol
> type nil to crlf, of course not for coding systems like binary).
No, I don't think toggle-buffer-file-coding-system should
change the default EOL type.
Agreed.
> 2. Sets buffer as modified (if not read-only). Why do you want
to
> toggle the eol type if you don't want to save the buffer?
I like it. I have long been wanted that
set-buffer-file-coding-system do the same but it didn't
annoyed me enough to submit a patch. :-)
This particular feature is already in the windows branch.
andy
8386
days inactive
8391
days old
8 comments
5 participants
participants (5)
-
Andy Piper -
Andy Piper -
Christoph Wedler -
Stephen J. Turnbull -
Yoshiki Hayashi