12:10 p.m.
Hello
I just tested the new org-8 branch and there are several issues.
- org needs the function face-at-point, which GNU emacs has in its
faces.el, we don't have, I just copied the function and it
worked. Could it please be added to faces.el or fsf-compat.el?
(defun face-at-point ()
"Return the face of the character after point.
If it has more than one face, return the first one.
Return nil if it has no specified face."
(let* ((faceprop (or (get-char-property (point) 'read-face-name)
(get-char-property (point) 'face)
'default))
(face (cond ((symbolp faceprop) faceprop)
;; List of faces (don't treat an attribute spec).
;; Just use the first face.
((and (consp faceprop) (not (keywordp (car faceprop)))
(not (memq (car faceprop)
'(foreground-color background-color))))
(car faceprop))
(t nil)))) ; Invalid face value.
(if (facep face) face nil)))
-
- the other issue has to do with the following error message
Debugger entered--Lisp error: (void-function call-process-shell-command)
call-process-shell-command("command" nil nil nil "-v"
"x11idle")
In the org mailing list it was argued, that
,----
|
| and it does not seem to have call-process-shell-command. This is
| a thin wrapper around call-process (which xemacs should have), so
| this should be easy to port.
`----
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
8:32 p.m.
>>>> Uwe Brauer <oub(a)mat.ucm.es> writes:
- org needs the function face-at-point, which GNU emacs has in
its
faces.el, we don't have, I just copied the function and it
worked. Could it please be added to faces.el or fsf-compat.el?
Just adding it to faces.el is best IMHO (and when we are at it maybe
see if there are more things to sync.)
Debugger entered--Lisp error: (void-function
call-process-shell-command)
call-process-shell-command("command" nil nil nil "-v"
"x11idle")
We have it from 21.5.33.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
10:40 p.m.
> "Mats" == Mats Lidell <matsl(a)xemacs.org> writes:
>>>>> Uwe Brauer <oub(a)mat.ucm.es> writes:
> - org needs the function face-at-point, which GNU emacs has in its
> faces.el, we don't have, I just copied the function and it
> worked. Could it please be added to faces.el or fsf-compat.el?
Just adding it to faces.el is best IMHO (and when we are at it maybe
see if there are more things to sync.)
> Debugger entered--Lisp error: (void-function
call-process-shell-command)
> call-process-shell-command("command" nil nil nil "-v"
"x11idle")
We have it from 21.5.33.
Cool.
I just downloaded it and compiled. There is a issue with specifer.c I
want to discuss in the next email.
Yours
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
12:39 a.m.
>>>> Uwe Brauer <oub(a)mat.ucm.es> writes:
- org needs the function face-at-point, which GNU emacs has in
its
faces.el, we don't have, I just copied the function and it
worked. Could it please be added to faces.el or
fsf-compat.el?
Are you sure it works as expected? I did some simple tests and it
seems to return nil always.
(defun face-at-point ()
[...]
(if (facep face) face nil)))
I think the problem is that GNU wants a face name in facep but we want
a face OBJECT. So the line above should be replaced with this (I think)
(if (find-face face) face nil)))
Comments anyone?
I also had a look in our faces.el and it seems like syncing isn't that
easy since we have our own implementation. So I guess just adding
face-at-point to faces.el will suffice.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
8:02 a.m.
Mats Lidell writes:
I think the problem is that GNU wants a face name in facep but we
want
a face OBJECT. So the line above should be replaced with this (I think)
(if (find-face face) face nil)))
In XEmacs it would be better style to just use (find-face face) there,
and use face-* functions to extract face properties ). If all you
want to do is return the name of the face, I suppose you can minimize
the diff this way, though.
I also don't understand what org-mode wants `face-at-point' to do.
It's documented
Return the face of the character after point.
If it has more than one face, return the first one.
Return nil if it has no specified face.
but this doesn't make a lot of sense in XEmacs, since multiple faces
are merged by redisplay, and I'm not sure why you'd want the "first"
face.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
10:25 a.m.
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
In XEmacs it would be better style to just use (find-face face)
there,
and use face-* functions to extract face properties ). If all you
want to do is return the name of the face, I suppose you can minimize
the diff this way, though.
I also don't understand what org-mode wants `face-at-point'
to do.
I haven't looked in org-mode so I don't now. Hence I suggested that
face-at-point returns the same as in GNU. Maybe a look in org-mode, or
general usage of face-at-point, could give a hint if returning the
face would be an easy solution. That would be best I think.
If not we are again facing (hmm...) the problem of whether we should
have a function that is compatible in name and in docs but actually
returns the right thing.
In our case maybe face-name-at-point would be a better function name
but then again there could be more than one face at a point if I
understand correctly. So we should return a list, face-names-at-point,
and suggest user to take the car of that!?
I guess if we understand what org-mode wants face-at-point with there
could be a totally different solution that fits us better. So looking
in org-mode is next thing here I suppose.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5:19 p.m.
Mats Lidell writes:
In our case maybe face-name-at-point would be a better function
name but then again there could be more than one face at a point if
I understand correctly.
Yes. Furthermore, apparently it's possible for that function to
return nil in Emacs, which makes no sense to me since there is always
a face controlling appearance of every Emacs window, at least in
XEmacs. Not to mention that the value of a given face property such
as "font" may derive from the first face in the list, a later face in
the list, or a face not in the list at all (the fallback).
It's hard to avoid the feeling that it really doesn't matter what that
function returns....
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
9:04 a.m.
> "Mats" == Mats Lidell <matsl(a)xemacs.org> writes:
>>>>> Uwe Brauer <oub(a)mat.ucm.es> writes:
> - org needs the function face-at-point, which GNU emacs has in its
> faces.el, we don't have, I just copied the function and it
> worked. Could it please be added to faces.el or
> fsf-compat.el?
Are you sure it works as expected? I did some simple tests and it
seems to return nil always.
Hm I have not really succeeded to make org-8 work with xemacs.
It sort of works with xemacs -vanilla
but has conflicts with my init files and/or org-7 settings. Till I
resolve these issues I cannot really test the new org-8 version.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
4177
days inactive
4179
days old
7 comments
3 participants
participants (3)
-
Stephen J. Turnbull -
The XEmacs Package Smoketest -
Uwe Brauer