Heiko Muenkel writes:
There's a bug in the function
`pui-install-selected-packages'. Wrong
arguments are given to `package-get'. The following patch fixes
that. It adds also some usefull comments to the variable
`pui-package-install-dest-dir'.
--- package-ui.el.~1~ Mon Nov 2 10:15:29 1998
+++ package-ui.el Mon Nov 2 10:31:16 1998
@@ -39,7 +39,10 @@
(defcustom pui-package-install-dest-dir nil
"*If non-nil (Automatic) path to package tree to install packages in.
Otherwise, use old path for installed packages and make a guess for
-new ones."
+new ones.
+
+ATTENTION: The path must have a trailing slash (on UNIX systems) and
+ it must be listed in `package-locations'!"
:group 'pui
:tag "Install Location"
:type '(choice (const :tag "Automatic" nil)
@@ -332,7 +335,7 @@
(message "Installing selected packages ...") (sit-for 0)
(if (catch 'done
(mapcar (lambda (pkg)
- (if (not (package-get pkg
+ (if (not (package-get pkg nil nil
pui-package-install-dest-dir))
(throw 'done nil)))
pui-selected-packages)
Heiko, you need to send patches to xemacs-patches, otherwise, they get
lost. Also, you should make a ChangeLog entry.
Anyway, I think that while the change to `pui-install-selected-packages'
is correct, I disagree with the note in `pui-package-install-dest-dir'.
The correct patch for that is as follows:
1998-11-04 Colin Rafferty <colin(a)xemacs.org>
* package-admin.el (package-admin-add-binary-package): protect
setting of default-dir so that we always have a directory name.
? lisp/finder-inf.el
Index: lisp/package-admin.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/package-admin.el,v
retrieving revision 1.8
diff -u -r1.8 package-admin.el
--- package-admin.el 1998/10/13 07:36:45 1.8
+++ package-admin.el 1998/11/05 04:02:27
@@ -323,7 +323,7 @@
;; Insure that the current directory doesn't change
(save-excursion
(set-buffer buf)
- (setq default-directory pkg-dir)
+ (setq default-directory (file-name-as-directory pkg-dir))
(setq case-fold-search t)
(buffer-disable-undo)
(goto-char (setq start (point-max)))
;; Colin