jpw> I have a fix for XEmacs 21.4.5. When I built --with-gtk jpw> default faces weren't setup. Thanks for the analysis and proposed fix. I will ... eventually :-( ... get to this. You can speed things up by supplying a patch with ChangeLog to the proper channel. Preferred format for ChangeLog entry, see the ChangeLog for examples. Editing the ChangeLog directly and diff'ing works fine. But please don't send ordinary diffs or regular context diffs, ChangeLogs change so they don't apply. diff -U 0 format is wonderful, though. Patches should be context diffs, preferably diff -u format. Do the diff from the top source directory if convenient (ie, the files should appaer as lisp/ChangeLog and lisp/gtk-faces.el in the diff index lines). Send the patch to xemacs-patches(a)xemacs.org. Again, many thanks for your work. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.

jpw> I guess the guts of gtk-init-device-faces were quoted for a jpw> reason; Probably because a programmer in a big hurry ripped the code right out of another file, still trailing arteries and ligaments.... jpw> if you apply my fix then the default faces *are* setup just jpw> so, *but* you cannot change them with M-x customize-face or a jpw> custom-set-faces form. This isn't the fault of your patch. I don't know whether to blame the incompleteness of the GTK port or the general brokenness of Custom yet. Probably the latter. Look for recent threads on "can't set italic font" on xemacs-beta. I'll ask Bill P. Two comments on the patch itself. 1. It's preferable to have patches that list files as lisp/gtk-faces.el rather than ./lisp/gtk-faces.el. It's a minor thing, and I don't know how to get diff to produce that offhand. If and when you start using "cvs diff" this will solve itself. 2. No more text will be added to the ChangeLog.GTK file, ever. This is the ChangeLog for when GTK was a separate project. When GTK was merged into the mainline, a pointer to the ChangeLog.GTK was placed into the main ChangeLog, and since then all changes go there. You couldn't know that, though. Don't worry about 1, and I doubt you'll ever forget 2, now. :-) -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.