>>>> "Mike" == Mike FABIAN
<mfabian(a)suse.de> writes: 
    Mike> "Stephen J. Turnbull" <stephen(a)xemacs.org> さんは書きました:
> I nailed the "metacity maximize" bug last night
> (proof-of-concept patch coming soon), 
    Mike> Werner Fink <werner(a)suse.de> (added to CC:) also made a
    Mike> patch to fix this problem recently. I attach the patch for
    Mike> your reference.  Maybe it is helpful to compare your patch
    Mike> with Werner's.
Thank you!  They are actually quite different.
    Mike> I have not looked at Werner's patch in detail yet, if you
    Mike> have questions please ask Werner.
OK, I think I understand what Werner's patch does.  As I see it, it's
too generous to XEmacs.  There really was a _generic_ bug that only
happened to manifest when the window manager insists on pinning XEmacs
to an exact pixel size.  Only a few do that, and even those only when
maximizing.  So it wasn't observed until recently.
According to the ICCCM, the window manager has absolute control over
XEmacs's top-level geometry.  So XEmacs _was_ buggy, and this bug
needs to be fixed at that level; XEmacs must learn to obey the window
manager.  Mine does that, but I'm not sure if maybe more work isn't
needed.
I propose to keep Werner's patch in reserve in case there are problems
with mine.  I will commit mine and study his a bit more.
What do you think, Werner?
Also, does your patch do more than very carefully work around the
specific problem?  It looks quite specific to the maximize bug.
-- 
Institute of Policy and Planning Sciences     
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.