5:06 p.m.
Hello!
I fixed the following problem:
When hexl-find-file opens a file for which
font-locking is enabled (eg. a source code
file), the buffer is font-locked before
hexlify-buffer is called. This wastes time and
can lead to inappropriate font-locking in the
(then hexlified) buffer.
My solution is:
* in lisp/files.el:
- add a variable 'after-find-file-nomodes'
- modify 'after-find-file' so it doesn't
alter the file's mode if the variable
'after-find-file-nomodes' is non-nil.
* in xemacs-packages/lisp/text-modes/hexl.el:
- bind 'after-find-file-nomodes' to 't'
when calling 'find-file'.
If this solution is acceptable, I will
create a patch.
(Should I create separate patches for
lisp/files.el and the package text-modes?)
-Edwin
5:29 p.m.
Forgot to mention: I'm using (and fixing)
XEmacs 21.4.3
text-modes 1.31
I'd create the patch against CVS though,
if neccessary.
-Edwin
9:44 p.m.
Edwin Steiner wrote:
I fixed the following problem:
When hexl-find-file opens a file for which
font-locking is enabled (eg. a source code
file), the buffer is font-locked before
hexlify-buffer is called. This wastes time and
can lead to inappropriate font-locking in the
(then hexlified) buffer.
My solution is:
* in lisp/files.el:
- add a variable 'after-find-file-nomodes'
- modify 'after-find-file' so it doesn't
alter the file's mode if the variable
'after-find-file-nomodes' is non-nil.
* in xemacs-packages/lisp/text-modes/hexl.el:
- bind 'after-find-file-nomodes' to 't'
when calling 'find-file'.
If this solution is acceptable, I will
create a patch.
Sounds unnecessarily complex. I would have thought that it would be
better to have hexl-find-file either:
a) bind font-lock-auto-fontify and font-lock-mode-enable-list to nil,
b) bind find-file-hooks to nil, or
c) bypass find-file altogether, in favour of e.g. insert-file-contents
or even insert-file-contents literally.
To me, find-file seems too high level for something like hexl.
--
Glynn Clements <glynn.clements(a)virgin.net>
9:54 p.m.
Glynn Clements wrote:
Edwin Steiner wrote:
> I fixed the following problem:
>
> When hexl-find-file opens a file for which
> font-locking is enabled (eg. a source code
> file), the buffer is font-locked before
> hexlify-buffer is called. This wastes time and
> can lead to inappropriate font-locking in the
> (then hexlified) buffer.
>
> My solution is:
[proposal snipped]
Sounds unnecessarily complex. I would have thought that it would be
better to have hexl-find-file either:
a) bind font-lock-auto-fontify and font-lock-mode-enable-list to nil,
b) bind find-file-hooks to nil, or
normal-mode would still be called unneccessarily.
c) bypass find-file altogether, in favour of e.g.
insert-file-contents
or even insert-file-contents literally.
To me, find-file seems too high level for something like hexl.
I thought about it again. (I also found a hexl-relevant
bug in lisp/process.el and submitted a patch.)
The most simple and elegant solution is rewriting
hexl-find-file to:
(defun hexl-find-file (filename)
"Edit file FILENAME in hexl-mode.
Switch to a buffer visiting file FILENAME, creating one if none exists."
(interactive "fFilename: ")
(let ((find-file-run-dired nil))
(switch-to-buffer (find-file-noselect filename nil t))
(if (not (eq major-mode 'hexl-mode))
(hexl-mode))))
It uses the RAWFILE argument of find-file-noselect.
No change to files.el is required, no additional
variable is required, and it achieves the desired
effect.
When hexl-find-file finds a file, which is already
visited by a live buffer, font-lock is not disabled.
I wonder, if it should be disabled (*before* the
buffer is hexlified, to save time. Deactivating
font-lock in a hexl-mode-hook will not avoid the
unneccessary font-locking.)
If font-locking is disabled by hexlify-buffer, it
will still be off, if you leave hexl-mode via
hexl-mode-exit. Would this be a problem?
If someone uses customized font-locking for hexl-mode
(as I do sometimes), how can the original font-locking
be restored after hexl-mode-exit?
I hope I didn't miss anything. If there is no
disagreement with this solution, I will submit a patch.
There are still problems with hexl-mode. I found that
revert-buffer doesn't always work, and sometimes XEmacs
crashes when switching hexl-mode on or off (on my
Win98 machine). If I have enough time I will try to
debug this.
-Edwin
10:15 p.m.
Edwin Steiner writes:
When hexl-find-file finds a file, which is already
visited by a live buffer, font-lock is not disabled.
I wonder, if it should be disabled (*before* the
buffer is hexlified, to save time. Deactivating
font-lock in a hexl-mode-hook will not avoid the
unneccessary font-locking.)
Yes, I think that it should.
If font-locking is disabled by hexlify-buffer, it
will still be off, if you leave hexl-mode via
hexl-mode-exit. Would this be a problem?
Yes, it would be best if when hexl mode exits, the buffer were back in
its original state, with font-locking intact.
If someone uses customized font-locking for hexl-mode
(as I do sometimes), how can the original font-locking
be restored after hexl-mode-exit?
Good question. But for the most common case, anyhow, there will be no
font-locking for hexl mode.
There are still problems with hexl-mode. I found that
revert-buffer doesn't always work, and sometimes XEmacs
crashes when switching hexl-mode on or off (on my
Win98 machine). If I have enough time I will try to
debug this.
Excellent, good luck with the debugging.
11:15 p.m.
Edwin Steiner wrote:
When hexl-find-file finds a file, which is already
visited by a live buffer, font-lock is not disabled.
I wonder, if it should be disabled (*before* the
buffer is hexlified, to save time. Deactivating
font-lock in a hexl-mode-hook will not avoid the
unneccessary font-locking.)
If font-locking is disabled by hexlify-buffer, it
will still be off, if you leave hexl-mode via
hexl-mode-exit. Would this be a problem?
If someone uses customized font-locking for hexl-mode
(as I do sometimes), how can the original font-locking
be restored after hexl-mode-exit?
I think that this is a more general problem with changing the major
mode, particularly when changing to or from a "special" mode.
change-major-mode-hook is probably run too early on for this purpose.
It would be useful if there was a hook which was called after the
corresponding function had completed; but, AFAICT, there isn't one.
--
Glynn Clements <glynn.clements(a)virgin.net>
8321
days inactive
8323
days old
5 comments
5 participants
participants (5)
-
Charles Waldman -
Edwin Steiner -
Edwin Steiner -
Edwin Steiner -
Glynn Clements