Re: Tabs, the gutter, `window-height', scrolling. (Was: Re: OK I give up)
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Andy Piper <andy(a)xemacs.org> writes:
> I looked at `window-height', and see that it accounts for
the
> modeline and possible scrollbar, but it does not (yet) account for
> the tab gutter, and needs to. I am not capable at this time of
> making that patch, or I would. I just plain don't understand things
> well enough yet to monkey with it.
If page down is using window-height then that is the bug - it should use
window-displayed-height instead. window-height should yield consistent
geometries, not accurate numbers of lines.
Aha... So this is what is breaking things like ispell's computation
for its window.
I really think you want to change window height to take the gutter
into account. window-height is really meant to do as good an
approximation of window-displayed-height without doing a redisplay.
The main purpose is to make code from the pre-varying-height-font era
(i.e. FSF code) work correctly.
Jan
Kyle Jones
Thursday, 13 January
Thu, 13 Jan
2:51 a.m.
New subject: Tabs, the gutter, `window-height', scrolling. (Was: Re: OK I give up)
Jan Vroonhof writes:
I really think you want to change window height to take the gutter
into account. window-height is really meant to do as good an
approximation of window-displayed-height without doing a redisplay.
The main purpose is to make code from the pre-varying-height-font era
(i.e. FSF code) work correctly.
I agree. The gutter is a frame element. Only per window
elements like scrollbars and modelines should steal space from
window-height. The gutter should steal space from the frame
before the remaining space is allocated for the windows.
Andy Piper
Thursday, 13 January
Thu, 13 Jan
8:25 a.m.
New subject: Tabs, the gutter, `window-height', scrolling. (Was: Re: OK I give up)
At 08:41 PM 1/12/00 +0100, Jan Vroonhof wrote:
Aha... So this is what is breaking things like ispell's
computation
for its window.
I really think you want to change window height to take the gutter
into account. window-height is really meant to do as good an
approximation of window-displayed-height without doing a redisplay.
The main purpose is to make code from the pre-varying-height-font era
(i.e. FSF code) work correctly.
Its easy to fix:
--- window.c~ Wed Jan 12 15:56:40 2000
+++ window.c Thu Jan 13 08:24:04 2000
＠＠ -1297,7 +1297,7 ＠＠
*/
(window))
{
- return make_int (window_char_height (decode_window (window), 1));
+ return make_int (window_char_height (decode_window (window), 0));
}
DEFUN ("window-displayed-height", Fwindow_displayed_height, 0, 1, 0, /*
It just didn't seem like this was what was intended. If you think this is a
reasonable fix then I will apply it.
andy
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd
9081
days inactive
9082
days old
2 comments
3 participants
tags (0)
participants (3)
-
Andy Piper -
Jan Vroonhof -
Kyle Jones