10:31 a.m.
Hi,
I am using 21.5.2 CVS (main trunk). Is the following behavior
correct?
(int-to-char -51)
=> ?\^^M
If so, we should modify mule-packages/egg-its/egg.el not to use
negative numbers for `int-to-char'. Because of this behavior,
Egg often hangs up when I mis-type (e.g. C--) in the fence-mode.
Here is a patch for egg.el:
2001-08-21 Katsumi Yamaoka <yamaoka(a)jpl.org>
* egg.el (egg-read-event): Don't specify a negative number to
`int-to-char'.
--- mule-packages/egg-its/egg.el~ Tue May 8 11:18:52 2001
+++ mule-packages/egg-its/egg.el Tue Aug 21 09:29:36 2001
＠＠ -166,8 +166,12 ＠＠
(if (eq 1 (event-modifier-bits event))
(setq ch
(if (characterp key)
- (or (int-to-char (- (char-to-int key) 96))
- (int-to-char (- (char-to-int key) 64)))
+ (progn
+ (setq key (char-to-int key))
+ (or (and (>= key 96)
+ (int-to-char (- key 96)))
+ (and (>= key 64)
+ (int-to-char (- key 64)))))
(event-to-character event)))
(setq unread-command-events (list event))))
(setq unread-command-events (list event)))
3:02 a.m.
This "sounds" OK to me. Could somebody more knowledgeable than I
please comment.
|--==> "KY" == Katsumi Yamaoka <yamaoka(a)jpl.org> writes:
KY> Hi,
KY> I am using 21.5.2 CVS (main trunk). Is the following behavior
KY> correct?
KY> (int-to-char -51)
KY> => ?\^^M
KY> If so, we should modify mule-packages/egg-its/egg.el not to use
KY> negative numbers for `int-to-char'. Because of this behavior,
KY> Egg often hangs up when I mis-type (e.g. C--) in the fence-mode.
KY> Here is a patch for egg.el:
KY> 2001-08-21 Katsumi Yamaoka <yamaoka(a)jpl.org>
KY> * egg.el (egg-read-event): Don't specify a negative number to
KY> `int-to-char'.
KY> --- mule-packages/egg-its/egg.el~ Tue May 8 11:18:52 2001
KY> +++ mule-packages/egg-its/egg.el Tue Aug 21 09:29:36 2001
KY> ＠＠ -166,8 +166,12 ＠＠
KY> (if (eq 1 (event-modifier-bits event))
KY> (setq ch
KY> (if (characterp key)
KY> - (or (int-to-char (- (char-to-int key) 96))
KY> - (int-to-char (- (char-to-int key) 64)))
KY> + (progn
KY> + (setq key (char-to-int key))
KY> + (or (and (>= key 96)
KY> + (int-to-char (- key 96)))
KY> + (and (>= key 64)
KY> + (int-to-char (- key 64)))))
KY> (event-to-character event)))
KY> (setq unread-command-events (list event))))
KY> (setq unread-command-events (list event)))
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
5:23 a.m.
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SY> This "sounds" OK to me. Could somebody more knowledgeable
SY> than I please comment.
It's a bug in int-to-char:
`int-to-char' is a built-in function
(int-to-char INTEGER)
Documentation:
Convert integer INTEGER into the equivalent character.
Not all integers correspond to valid characters; use `char-int-p' to
determine whether this is the case. If the integer cannot be converted,
nil is returned.
21.4.4 returns nil in Yamaoka-san's example.
What does EGG do with nil? If its behavior is sensible, then we should
just fix 21.5.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
6:25 a.m.
>>>> In
<15237.54965.578347.14883(a)turnbull.sk.tsukuba.ac.jp>
>>>> "Stephen J. Turnbull" <turnbull(a)sk.tsukuba.ac.jp> wrote:
>>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SY> This "sounds" OK to me. Could somebody more
knowledgeable
SY> than I please comment.
It's a bug in int-to-char:
[...]
21.4.4 returns nil in Yamaoka-san's example.
Yes. It occurs only in latest 21.5.2.
What does EGG do with nil?
Nil for negative arg is OK, if anything, it seems that Jareth
uses that behavior deliberately in `egg-read-event'.
If its behavior is sensible, then we should just fix 21.5.
I hope so. Thanks.
--
Katsumi Yamaoka <yamaoka(a)jpl.org>
8:56 a.m.
New subject: [VETO] `int-to-char' returns a char even if arg is negative
VETO
The bug is in buffer.h, not in EGG. Patch forthcoming.
>>>> "KY" == Katsumi Yamaoka
<yamaoka(a)jpl.org> writes:
2001-08-21 Katsumi Yamaoka <yamaoka(a)jpl.org>
* egg.el (egg-read-event): Don't specify a negative number to
`int-to-char'.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
9:07 a.m.
New subject: [VETO] `int-to-char' returns a char even if arg is negative
>>>> In
<15238.2208.462413.302073(a)turnbull.sk.tsukuba.ac.jp>
>>>> "Stephen J. Turnbull" <turnbull(a)sk.tsukuba.ac.jp> wrote:
VETO
The bug is in buffer.h, not in EGG. Patch forthcoming.
2001-08-21 Katsumi Yamaoka <yamaoka(a)jpl.org>
* egg.el (egg-read-event): Don't specify a negative number to
`int-to-char'.
Thanks Stephen, I call it off myself.
--
Katsumi Yamaoka <yamaoka(a)jpl.org>
8491
days inactive
8494
days old
5 comments
3 participants
participants (3)
-
Katsumi Yamaoka -
Stephen J. Turnbull -
Steve Youngs