>>>> "David" == David Bush
<David.Bush(a)intel.com> writes:
David> While comparing the implementations of USE_KKCC in event-msw.c with
David> those in event-Xt.c, I noticed some apparent problems. I'm not in a
David> position to test under X so I'm describing the problems without
David> offering patches.
David> 1) In x_to_emacs_keysym at lines 1070 to 1077, the mutator macros
David> SET_KEY_DATA_MODIFIERS and SET_KEY_DATA_KEYSYM are used without
David> first creating the key data object through a call to
David> set_event_type. And I believe that XEVENT_DATA rather than
David> XKEY_DATA should be used to wrap the emacs event object.
David> 2) In enqueue_focus_event at line 1688 the address of the x event
David> object is taken before the object is allocated throught the
David> set_event_type call.
You're entirely correct. I'll fix this by tomorrow, in all
probability. Many thanks for looking at the code so closely!
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla