8:20 a.m.
If ansi-color.el is now part of XEmacs, should I send patches to this
list or to xemacs-patches? I got a patch by Dave Love for :version
attributes. Those are not correct for XEmacs. Does that bother you?
If so, what should I put there instead?
:version (if (featurep 'xemacs "21.3") "21.1")
The same info is missing for what Stephen J. Turnbull said:
1. We would probably want to add the ansi-colors Custom group
to
relevant XEmacs-specific groups (in particular, package system
related groups). This would best be done in ansi-colors.el
itself, probably conditional on (featurep 'xemacs). Any
problem with that?
If you guys tell me what is needed, I'll add it. :)
Alex.
2001-01-11 Alex Schroeder <alex(a)gnu.org>
* ansi-color.el (ansi-colors) <defgroup>: Fix :version by Dave
Love <fx(a)gnu.org>
(ansi-color-for-comint-mode): Fix :version.
2001-01-10 Alex Schroeder <alex(a)gnu.org>
* ansi-color.el (ansi-color-unfontify-region): Doc change.
~/elisp/ansi-colors $ cvs diff -c -r REL-3-4-0
cvs diff: Diffing .
Index: ansi-color.el
===================================================================
RCS file: /home/cvsroot/emacs/ansi-colors/ansi-color.el,v
retrieving revision 1.25
retrieving revision 1.28
diff -c -r1.25 -r1.28
*** ansi-color.el 2001/01/07 02:24:23 1.25
--- ansi-color.el 2001/01/14 16:13:00 1.28
***************
*** 1,11 ****
;;; ansi-color.el --- translate ANSI escape sequences into faces
! ;; Copyright (C) 1999, 2000 Free Software Foundation, Inc.
;; Author: Alex Schroeder <alex(a)gnu.org>
;; Maintainer: Alex Schroeder <alex(a)gnu.org>
! ;; Version: 3.4.0
! ;; Keywords: comm processes
;; This file is part of GNU Emacs.
--- 1,11 ----
;;; ansi-color.el --- translate ANSI escape sequences into faces
! ;; Copyright (C) 1999, 2000, 2001 Free Software Foundation, Inc.
;; Author: Alex Schroeder <alex(a)gnu.org>
;; Maintainer: Alex Schroeder <alex(a)gnu.org>
! ;; Version: 3.4.2
! ;; Keywords: comm processes terminals services
;; This file is part of GNU Emacs.
***************
*** 95,101 ****
Rendition) control sequences are defined in section 3.8.117 of the
ECMA-48 standard \(identical to ISO/IEC 6429), which is freely available
as a PDF file <URL:http://www.ecma.ch/ecma1/STAND/ECMA-048.HTM>."
! :version "20.7"
:group 'processes)
(defcustom ansi-color-faces-vector
--- 95,101 ----
Rendition) control sequences are defined in section 3.8.117 of the
ECMA-48 standard \(identical to ISO/IEC 6429), which is freely available
as a PDF file <URL:http://www.ecma.ch/ecma1/STAND/ECMA-048.HTM>."
! :version "21.1"
:group 'processes)
(defcustom ansi-color-faces-vector
***************
*** 172,178 ****
\\[ansi-color-for-comint-mode-on]
\\[ansi-color-for-comint-mode-off]
\\[ansi-color-for-comint-mode-filter]"
! :version "20.8"
:type '(choice (const :tag "Do nothing" nil)
(const :tag "Filter" filter)
(const :tag "Translate" t))
--- 172,178 ----
\\[ansi-color-for-comint-mode-on]
\\[ansi-color-for-comint-mode-off]
\\[ansi-color-for-comint-mode-filter]"
! :version "21.1"
:type '(choice (const :tag "Do nothing" nil)
(const :tag "Filter" filter)
(const :tag "Translate" t))
***************
*** 218,224 ****
'ansi-color-process-output)
! ;; Alternative font-lock-unfontify-region-function
(eval-when-compile
--- 218,224 ----
'ansi-color-process-output)
! ;; Alternative font-lock-unfontify-region-function for Emacs only
(eval-when-compile
***************
*** 238,246 ****
(put 'save-buffer-state 'lisp-indent-function 1))
(defun ansi-color-unfontify-region (beg end &rest xemacs-stuff)
! "Replacement function for `font-lock-default-unfontify-region'.
! When font-lock is active in a buffer, you cannot simply add face
! text-properties to the buffer. Font-lock will remove the face
text-property using `font-lock-unfontify-region-function'. If you want
to insert the strings returned by `ansi-color-apply' into such buffers,
you must set `font-lock-unfontify-region-function' to
--- 238,249 ----
(put 'save-buffer-state 'lisp-indent-function 1))
(defun ansi-color-unfontify-region (beg end &rest xemacs-stuff)
! "Replacement function for `font-lock-default-unfontify-region'.
!
! As text-properties are implemented using extents in XEmacs, this
! function is probably not needed. In Emacs, however, things are a bit
! different: When font-lock is active in a buffer, you cannot simply add
! face text-properties to the buffer. Font-lock will remove the face
text-property using `font-lock-unfontify-region-function'. If you want
to insert the strings returned by `ansi-color-apply' into such buffers,
you must set `font-lock-unfontify-region-function' to
12:24 a.m.
New subject: add ansi-color.el to XEmacs?
Alex Schroeder <alex(a)gnu.org> writes:
If ansi-color.el is now part of XEmacs, should I send patches to
this
list or to xemacs-patches?
Well it's not actually a part of XEmacs yet but it will be soon when I
add it to one of our packages. This will happen next week sometime.
After that you can submit patches to <xemacs-patches(a)xemacs.org>.
I'd like very much for you to maintain ansi-color.el directly. With
that in mind, can you send me your public ssh key so I can arrange CVS
commit access to your code.
I got a patch by Dave Love for :version
attributes. Those are not correct for XEmacs. Does that bother you?
It bothers me if it breaks anything for XEmacs, or even if it spews out
an annoying error/warning.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
2:21 a.m.
New subject: add ansi-color.el to XEmacs?
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SY> Alex Schroeder <alex(a)gnu.org> writes:
> I got a patch by Dave Love for :version attributes. Those are
> not correct for XEmacs. Does that bother you?
SY> It bothers me if it breaks anything for XEmacs, or even if it
SY> spews out an annoying error/warning.
I believe the fix discussed (Per Abrahamsen's suggestion, IIRC) was to
make XEmacs ignore them.[1] So Alex should leave them in for now,
without conditionalization, until that's been settled.
Footnotes:
[1] Evidently the design is not really appropriate for separate
development of packages and core, as I understand it. *sigh*
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
8702
days inactive
8703
days old
2 comments
3 participants
participants (3)
-
Alex Schroeder -
Stephen J. Turnbull -
Steve Youngs