8:36 p.m.
(Resent with attachment)
Michael Sperber <sperber(a)informatik.uni-tuebingen.de> writes:
APPROVE COMMIT 21.5
This (hopefully) fixes a regression in 21.5 reported by Vin.
2005-12-30 Mike Sperber <mike(a)xemacs.org>
* packages.el (packages-find-all-package-hierarchies): Interpret
EMACSPACKAGEPATH as listing package direcories, not hierarchies.
This fixes a regression introduced in the change on 2005-01-08.
Hi, Mike!
Yes, that works. Thank you very much.
My career as a prognosticator is in jeopardy, however, because once
I've applied this, it turns out that the 21.5 version of my patch to
find packages at run-time in ../xemacs-packages (attached) still
doesn't work. [Can you believe it?! :-) ]
Your original advice was to modify the root-finding code, and I have
done that; with my modification installed, the parent of the
xemacs-packages directory is correctly found as a root and a data
root, but the xemacs-packages directory does not get searched and
added to load-path.
This technique worked for 21.4, but I guess there must be an extra
step required for 21.5. Mike, do you have any suggestions for
debugging this?
Thank you and Happy New Year!
- vin
6:34 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
[Sorry for the late reply!]
Vin Shelton <acs(a)xemacs.org> writes:
Your original advice was to modify the root-finding code, and I have
done that; with my modification installed, the parent of the
xemacs-packages directory is correctly found as a root and a data
root, but the xemacs-packages directory does not get searched and
added to load-path.
I'll do this, along with a few other patches cleaning up this code.
Two questions:
Index: lisp/setup-paths.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/setup-paths.el,v
retrieving revision 1.21
diff -a -u -r1.21 setup-paths.el
--- lisp/setup-paths.el 2004/12/27 12:25:15 1.21
+++ lisp/setup-paths.el 2005/12/28 16:54:05
＠＠ -102,12 +102,18 ＠＠
;; in-place or windows-nt
(and
(paths-file-readable-directory-p (paths-construct-path (list directory
"lisp")))
- (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))))
+ (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))
I'm worried about code accretion in `paths-emacs-root-p' and
`emacs-data-root-p'---could you send me a directory tree listing of
the Windows XEmacs, and possibly give me an idea what environment
variables/registry settings/configure-xxx variables are set on
Windows?
-(defun paths-find-emacs-root (invocation-directory invocation-name)
- "Find the run-time root of XEmacs.
+ ;; searching for a package directory
+ (and
+ (string-match "win32\\|cygwin" system-configuration)
+ (paths-file-readable-directory-p (paths-construct-path (list directory
"xemacs-packages"))))))
I'm wondering---shouldn't this be `(eq system-type 'windows-nt)'. I
don't even know if that would include Cygwin. But shouldn't Cygwin be
more like Unix than like Windows native?
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
10:27 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
Hi Michael,
Thanks for picking this up.
On 2/13/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
[Sorry for the late reply!]
Vin Shelton <acs(a)xemacs.org> writes:
> Your original advice was to modify the root-finding code, and I have
> done that; with my modification installed, the parent of the
> xemacs-packages directory is correctly found as a root and a data
> root, but the xemacs-packages directory does not get searched and
> added to load-path.
I'll do this, along with a few other patches cleaning up this code.
Two questions:
> Index: lisp/setup-paths.el
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/setup-paths.el,v
> retrieving revision 1.21
> diff -a -u -r1.21 setup-paths.el
> --- lisp/setup-paths.el 2004/12/27 12:25:15 1.21
> +++ lisp/setup-paths.el 2005/12/28 16:54:05
> ＠＠ -102,12 +102,18 ＠＠
> ;; in-place or windows-nt
> (and
> (paths-file-readable-directory-p (paths-construct-path (list directory
"lisp")))
> - (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))))
> + (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))
I'm worried about code accretion in `paths-emacs-root-p' and
`emacs-data-root-p'---could you send me a directory tree listing of
the Windows XEmacs, and possibly give me an idea what environment
variables/registry settings/configure-xxx variables are set on
Windows?
Here is the directory structure I want to support; under a common
root, I want to have the following directories:
XEmacs-21.4.19/
PROBLEMS etc/ i586-pc-win32/ info/ lisp/ lock/
XEmacs-21.5-b24/
COPYING PROBLEMS etc/ info/ lock/
Installation README i586-pc-win32/ lisp/
mule-packages
site-packages
xemacs-packages
Do you need more detail, or is that sufficient? Note that I
personally can build XEmacs 21.4 and XEmacs 21.5 to support this
structure, but I cannot make an installable kit that will support this
structure for 21.5. That is, the 'common root' must be hard-coded for
21.5. (For 21.4, there is no problem - the changes we have made
support finding the common root at run-time.)
Attached is the contents of my 21.5 Installation file.
I have not fiddled with registry settings or environment variables.
Here is the output of
'diff -u nt/config.inc.samp nt/config.inc':
--- nt/config.inc.samp 2005-11-24 20:41:50.000000000 -0500
+++ nt/config.inc 2006-02-06 07:51:43.347154000 -0500
＠＠ -4,9 +4,9 ＠＠
# Install options #
############################################################################
-INSTALL_DIR=c:\Program Files\XEmacs\XEmacs-$(XEMACS_VERSION_STRING)
+INSTALL_DIR=e:\XEmacs\XEmacs-$(XEMACS_VERSION_STRING)
-PACKAGE_PREFIX=c:\Program Files\XEmacs
+PACKAGE_PREFIX=e:\XEmacs
############################################################################
# Compiled-in features: basic #
＠＠ -31,7 +31,7 ＠＠
# (a self-installing .ZIP) and unzip them into an appropriate directory
# (by default, c:\src). This gets you precompiled versions of all of
# the libraries below.
-OPTIONAL_LIBRARY_DIR=c:\src
+OPTIONAL_LIBRARY_DIR=..\..
# Set this to enable XPM support (virtually mandatory), and specify
# the directory containing xpm. Get the library from
＠＠ -52,7 +52,7 ＠＠
# so we can preserve the version number, like for the other libraries.
HAVE_PNG=1
PNG_DIR=$(OPTIONAL_LIBRARY_DIR)\libpng-1.2.8
-ZLIB_DIR=$(OPTIONAL_LIBRARY_DIR)\zlib-1.2.3
+ZLIB_DIR=$(OPTIONAL_LIBRARY_DIR)\zlib
# Set this to enable JPEG support (useful, but not necessary), and specify
# the directory containing jpeg. Get the latest version from
＠＠ -69,7 +69,7 ＠＠
# Set this to enable XFace support (not very important), and specify the
# directory containing compface. Get the library from
# http://ftp.xemacs.org/aux/compface-1.5.1.tar.gz.
-HAVE_XFACE=1
+HAVE_XFACE=0
COMPFACE_DIR=$(OPTIONAL_LIBRARY_DIR)\compface-1.5.1
# Set this to enable bignum support (useful, but not necessary), and specify
＠＠ -149,7 +149,7 ＠＠
# Cygwin sitting around already. If not, you should. Cygwin provides a
# `makeinfo.exe' in /usr/bin/makeinfo (/usr/bin is virtual, it's /bin in
# the actual file system).
-MAKEINFO=c:\cygwin\bin\makeinfo.exe
+MAKEINFO=e:\cygwin\bin\makeinfo.exe
# Set this to enable debug code in XEmacs that doesn't slow things down,
# and to add debugging information to the executable. (The code that's
>
> -(defun paths-find-emacs-root (invocation-directory invocation-name)
> - "Find the run-time root of XEmacs.
> + ;; searching for a package directory
> + (and
> + (string-match "win32\\|cygwin" system-configuration)
> + (paths-file-readable-directory-p (paths-construct-path (list directory
"xemacs-packages"))))))
I'm wondering---shouldn't this be `(eq system-type 'windows-nt)'. I
don't even know if that would include Cygwin. But shouldn't Cygwin be
more like Unix than like Windows native?
Perhaps. I can't remember why I changed that code, but the
'win32|cygwin' match is the way I wrote the code in 21.4 and I haven't
noticed any deleterious effects.
Regards,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
7:30 a.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
Hi Vin!
Thanks for the info!
Vin Shelton <acs(a)xemacs.org> writes:
Here is the directory structure I want to support; under a common
root, I want to have the following directories:
XEmacs-21.4.19/
PROBLEMS etc/ i586-pc-win32/ info/ lisp/ lock/
XEmacs-21.5-b24/
COPYING PROBLEMS etc/ info/ lock/
Installation README i586-pc-win32/ lisp/
mule-packages
site-packages
xemacs-packages
Do you need more detail, or is that sufficient?
No, that should work.
[Installation]
Package path is
"~\\.xemacs;;e:\\XEmacs\\site-packages;e:\\XEmacs\\xemacs-packages".
This is your build setting, though, right? (I.e. not what's set in
the install kit.) What are the settings of the various
configure-<xxx> variables for the install kit?
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
12:43 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/15/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Hi Vin!
Thanks for the info!
Sure! Thanks for the help.
Vin Shelton <acs(a)xemacs.org> writes:
> Here is the directory structure I want to support; under a common
> root, I want to have the following directories:
> XEmacs-21.4.19/
> PROBLEMS etc/ i586-pc-win32/ info/ lisp/ lock/
> XEmacs-21.5-b24/
> COPYING PROBLEMS etc/ info/ lock/
> Installation README i586-pc-win32/ lisp/
> mule-packages
> site-packages
> xemacs-packages
>
> Do you need more detail, or is that sufficient?
No, that should work.
> [Installation]
> Package path is
"~\\.xemacs;;e:\\XEmacs\\site-packages;e:\\XEmacs\\xemacs-packages".
This is your build setting, though, right? (I.e. not what's set in
the install kit.) What are the settings of the various
configure-<xxx> variables for the install kit?
I'm not sure I understand the question. The installation kit will be
*built* on my machine with those settings, but will be installed
somewhere of the user's choosing. I want to build the kits on my
machine but enable the users to install them wherever they choose.
Typically, the users would install in:
C:\Program Files\XEmacs
XEmacs-21.4.19/
XEmacs-21.5-b24/
mule-packages/
site-packages/
xemacs-packages/
with the package directories common to the installed 21.4. and 21.5
kits. There would be an install kit for 21.4 and a separate install
kit for 21.5.
Here's how kit generation works:
1. I configure, build and install a 21.5 version of XEmacs.
2. I run InnoSetup, which takes the installed 21.5 tree and makes a
setup kit (essentially a fancy zip file).
3. User downloads the kit, runs the setup kit and decides where s/he
wants to install the kit. The root of the installation directory
defaults to C:\Program Files\XEmacs, but could be anywhere of the
user's choosing.
Is this what you wanted to know?
Regards,
Vin
4:32 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
Vin Shelton <acs(a)xemacs.org> writes:
On 2/15/06, Michael Sperber
<sperber(a)informatik.uni-tuebingen.de> wrote:
> No, that should work.
> > [Installation]
> > Package path is
"~\\.xemacs;;e:\\XEmacs\\site-packages;e:\\XEmacs\\xemacs-packages".
>
> This is your build setting, though, right? (I.e. not what's set in
> the install kit.) What are the settings of the various
> configure-<xxx> variables for the install kit?
I'm not sure I understand the question. The installation kit will be
*built* on my machine with those settings, but will be installed
somewhere of the user's choosing. I want to build the kits on my
machine but enable the users to install them wherever they choose.
Yeah, but it seems you're compiling your own private package path into
the executable, which might surprise users. (And via the now obsolete
package-path setting, too.) Is that necessary?
It would still be helpful to know what the various configure-<...>
variables are set to in an XEmacs that's installed from the Windows
installer.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
8:10 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/20/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Vin Shelton <acs(a)xemacs.org> writes:
> On 2/15/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
>> No, that should work.
>> > [Installation]
>> > Package path is
"~\\.xemacs;;e:\\XEmacs\\site-packages;e:\\XEmacs\\xemacs-packages".
>>
>> This is your build setting, though, right? (I.e. not what's set in
>> the install kit.) What are the settings of the various
>> configure-<xxx> variables for the install kit?
>
> I'm not sure I understand the question. The installation kit will be
> *built* on my machine with those settings, but will be installed
> somewhere of the user's choosing. I want to build the kits on my
> machine but enable the users to install them wherever they choose.
Yeah, but it seems you're compiling your own private package path into
the executable, which might surprise users. (And via the now obsolete
package-path setting, too.) Is that necessary?
That just comes for free. :-) Take a look at nt/config.inc.samp for
a configuration file for Windows. When one is building on windows,
one copies nt/config.inc.samp into nt/config.inc and makes
modifications.
Attached is the one I used to build the most recent 21.4 setup kit.
It would still be helpful to know what the various configure-<...>
variables are set to in an XEmacs that's installed from the Windows
installer.
Now I understand what you want! Here are the values of all the
configure- variables I could find on a 21.4.19 installation installed
from the latest setup kit.
configure-data-directory
nil
configure-mail-lock-method
dot
configure-doc-directory
nil
configure-module-directory
nil
configure-exec-directory
nil
configure-mule-lisp-directory
nil
configure-exec-prefix-directory
nil
configure-package-path
("~\\.xemacs" "" "c:\\XEmacs-built\\site-packages"
"c:\\XEmacs-built\\xemacs-packages")
configure-info-directory
nil
configure-prefix-directory
"..\\"
configure-info-path
nil
configure-site-directory
nil
configure-lisp-directory
nil
configure-site-module-directory
nil
HTH,
Vin
7:16 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/20/06, Vin Shelton <acs(a)xemacs.org> wrote:
On 2/20/06, Michael Sperber
<sperber(a)informatik.uni-tuebingen.de> wrote:
> Yeah, but it seems you're compiling your own private package path into
> the executable, which might surprise users. (And via the now obsolete
> package-path setting, too.) Is that necessary?
That just comes for free. :-) Take a look at nt/config.inc.samp for
a configuration file for Windows. When one is building on windows,
one copies nt/config.inc.samp into nt/config.inc and makes
modifications.
Michael,
It had never occurred to me to omit PACKAGE_PREFIX from config.inc
when building under Windows. I just did this and the build succeeded,
but according to the Installation file, the executable ended up with a
default value of:
Package path is "~\\.xemacs;;c:\\Program
Files\\XEmacs\\site-packages;c:\\Program
Files\\XEmacs\\xemacs-packages".
Just FYI. It looks like the current windows native configuration code
forces a value for PACKAGE_PREFIX into the build process.
Any thoughts?
Thank you,
Vin
1:49 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
"Vin Shelton" <acs(a)xemacs.org> writes:
It had never occurred to me to omit PACKAGE_PREFIX from config.inc
when building under Windows. I just did this and the build succeeded,
but according to the Installation file, the executable ended up with a
default value of:
Package path is "~\\.xemacs;;c:\\Program
Files\\XEmacs\\site-packages;c:\\Program
Files\\XEmacs\\xemacs-packages".
This is bad---the value is just plain wrong. Any chance you could
undo *this* setting as well? Because then I'd finally have a
reasonably good idea of what's going on under Windows.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
9:02 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/26/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
"Vin Shelton" <acs(a)xemacs.org> writes:
> It had never occurred to me to omit PACKAGE_PREFIX from config.inc
> when building under Windows. I just did this and the build succeeded,
> but according to the Installation file, the executable ended up with a
> default value of:
>
> Package path is "~\\.xemacs;;c:\\Program
> Files\\XEmacs\\site-packages;c:\\Program
> Files\\XEmacs\\xemacs-packages".
This is bad---the value is just plain wrong. Any chance you could
undo *this* setting as well? Because then I'd finally have a
reasonably good idea of what's going on under Windows.
It's defined in nt/xemacs.mak. What do your recommend the default
value you be? Patches accepted gratefully.
- Vin
5:10 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
"Vin Shelton" <acs(a)alumni.princeton.edu> writes:
It's defined in nt/xemacs.mak. What do your recommend the
default
value you be? Patches accepted gratefully.
It should be undefined by default. Could you try that?
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
3:26 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/27/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
"Vin Shelton" <acs(a)alumni.princeton.edu> writes:
> It's defined in nt/xemacs.mak. What do your recommend the default
> value you be? Patches accepted gratefully.
It should be undefined by default. Could you try that?
Yes. I removed the machinery in xemacs.mak that forces PACKAGE_PATH
on by default and let XEmacs use the root to determine the package
path at runtime and this works.
I will be posting a patch for 21.5. Thanks for your help, Mike.
- Vin
3:30 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
"Vin Shelton" <acs(a)xemacs.org> writes:
Yes. I removed the machinery in xemacs.mak that forces PACKAGE_PATH
on by default and let XEmacs use the root to determine the package
path at runtime and this works.
I will be posting a patch for 21.5. Thanks for your help, Mike.
Thanks for *your* help! Don't do too much with the path-searching
machinery itself. I have something a bit more comprehensive in my
workspace for that, which I can now finish, I think.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
3:41 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/28/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
"Vin Shelton" <acs(a)xemacs.org> writes:
> Yes. I removed the machinery in xemacs.mak that forces PACKAGE_PATH
> on by default and let XEmacs use the root to determine the package
> path at runtime and this works.
>
> I will be posting a patch for 21.5. Thanks for your help, Mike.
Thanks for *your* help! Don't do too much with the path-searching
machinery itself. I have something a bit more comprehensive in my
workspace for that, which I can now finish, I think.
You have seen the original part of the patch - it is comprised of the
setup-paths.el changes analogous to the find-paths.el changes I made
for 21.4.
- Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
4:54 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
"Vin Shelton" <acs(a)xemacs.org> writes:
You have seen the original part of the patch - it is comprised of
the
setup-paths.el changes analogous to the find-paths.el changes I made
for 21.4.
Right---my work is based on that, and I can now apply some
simplifications. But you will be checking in the patch to zap
PACKAGE_PATH, right?
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
7:15 p.m.
New subject: [AC21.5] Fix EMACSPACKAGEPATH
On 2/28/06, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
"Vin Shelton" <acs(a)xemacs.org> writes:
> You have seen the original part of the patch - it is comprised of the
> setup-paths.el changes analogous to the find-paths.el changes I made
> for 21.4.
Right---my work is based on that, and I can now apply some
simplifications. But you will be checking in the patch to zap
PACKAGE_PATH, right?
I will submit a patch and see what feedback I get. (The message is in
my drafts folder even as I type this.) I certainly plan on checking
in my patch to zap the default setting of PACKAGE_PATH, but we'll have
to see what comments and suggestions people have.
- Vin
6842
days inactive
6902
days old
15 comments
3 participants
participants (3)
-
Michael Sperber -
Vin Shelton -
Vin Shelton