I've had enough of being stressed out by my day job! I'm going to fix
something on XEmacs today, by golly!
"Steven T. Hatton" <hattons(a)globalsymmetry.com> wrote:
The speedbar no longer works for me. It launches OK, but as soon as
mouse over it, it sends error messages to the frame from which I
launch it. The errors are listed at the end of this message. It also
beeps as I move the mouse over any part of the speedbar window.
It looks like the problem is in saved-window-equal (in
window-xemacs.el). The test is blowing up because it is using = on
saved-window-modeline-hscroll, but that is nil for the speedbar (see the
description of the modeline-hscroll function). The patch below fixes
the problem for me. I don't really know this code, though, so somebody
tell me if eq is okay, or if it should be equal.
It's worth noting to whoever is working on this code that the eq test at
the top of saved-window-equal will never succeed, because we're making a
new structure every time (see save-window-excursion). This looks like
an opportunity for some caching.
2003-03-24 Jerry James <james(a)xemacs.org>
* window-xemacs.el (saved-window-equal): Use eq instead of = to
compare saved-window-modeline-hscroll values.
xemacs-21.5 source patch:
Diff command: cvs -q diff -uN
Files affected: lisp/window-xemacs.el
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/window-xemacs.el,v
retrieving revision 1.16
diff -d -u -u -r1.16 window-xemacs.el
--- lisp/window-xemacs.el 2003/02/06 06:35:48 1.16
+++ lisp/window-xemacs.el 2003/03/24 23:16:10
＠＠ -170,8 +170,8 ＠＠
(= (saved-window-hscroll saved-1)
- (= (saved-window-modeline-hscroll saved-1)
- (saved-window-modeline-hscroll saved-2))
+ (eq (saved-window-modeline-hscroll saved-1)
+ (saved-window-modeline-hscroll saved-2))
(eq (saved-window-dedicatedp saved-1)
(maybe-saved-window-equal (saved-window-first-hchild saved-1)