6:47 p.m.
Hi
I think there is a bug in the regular expression in mc-gpg.el
which is used in mailcrypt-3.5.5 together with gnupg-1.0.5.
This is what Brian Warner gets whith his version of gpg:
;31:warner＠zs2-pc4% gpg --list-secret-keys --with-colons --no-greeting
;/home/warner/.gnupg/secring.gpg
;-------------------------------
;sec::1024:17:1FE9CBFDC63B6750:1998-08-04:0:::Brian Warner (temporary GPG key)
<warner(a)lothar.com>:
;ssb::1024:20:C68E8DE9F759FBDE:1998-08-04:0:::
;sec::768:17:16BD446D567E33CF:1998-08-04:0:::signature (sample signature key)
<key＠key>:
;sec::768:16:D514CB72B37D9AF4:1998-08-04:0:::crypt (crypt) <crypt＠crypt>:
;sec::1024:17:4DBDD3258230A3E0:1998-08-04:0:::dummyy <d＠d>:
;ssb::1024:20:549B0E6CBBBB43D1:1998-08-04:0:::
And this is his regexp for matching:
(key-regexp
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):$"
)
I'm using gpg-1.05 compiled under cygwin (passing all tests) with (see subject) and I
get:
[712]> gpg --list-secret-keys --no-greeting --batch --with-colons
/users/vzell/.gnupg/secring.gpg
-------------------------------
sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker Zell (Ciko)
<dr.volker.zell＠oracle.com>:::
ssb::1024:16:2179761C5E488513:2001-05-18:::::::
vzell＠VZELL /tmp
[713]> gpg --list-secret-keys --no-greeting --batch --with-colons "Dr. Volker Zell
(Ciko) <dr.volker.zell(a)oracle.com>"
sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker Zell (Ciko)
<dr.volker.zell＠oracle.com>::scESC:
ssb::1024:16:2179761C5E488513:2001-05-18::::::e:
As you can see I get two more : at the end of each line. Therefore I have to use the
following
regexp. But then everything works. At least for me.
(key-regexp
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\)[^:]*:[^:]*:[^:]*:$"
)
Ciao
Volker
10:17 p.m.
>>>> "Volker" == Volker Zell <Dr.> writes:
Volker> Hi I think there is a bug in the regular expression in
Volker> mc-gpg.el which is used in mailcrypt-3.5.5 together with
Volker> gnupg-1.0.5.
I'm seeing the same problems with XEmacs 21.5 beta 1 "anise",
mailcrypt-3.5.5, GnuPG 1.0.5, under Linux (Redhat 7.1).
I've downgraded to GnuPG 1.0.4 in the mean time.
As I've mentioned, I'm not to bright - how do I go about
applying/testing Volker's fix?
Do I just hack mc-gpg.el and rebuild Mailcrypt?
What about code to detect GnuPG <= 1.0.4 and => 1.0.5 - is it possible
to detect this and add it to Mailcrypt so as not to break old GnuPG
versions with Mailcrypt (even tho everyone should upgrade :-)
I think I should start learning Elisp :-)
Baz.
Volker> This is what Brian Warner gets whith his version of gpg:
Volker> ;31:warner＠zs2-pc4% gpg --list-secret-keys --with-colons
Volker> --no-greeting ;/home/warner/.gnupg/secring.gpg
Volker> ;-------------------------------
Volker> ;sec::1024:17:1FE9CBFDC63B6750:1998-08-04:0:::Brian Warner
Volker> (temporary GPG key) <warner(a)lothar.com>:
Volker> ;ssb::1024:20:C68E8DE9F759FBDE:1998-08-04:0:::
Volker> ;sec::768:17:16BD446D567E33CF:1998-08-04:0:::signature
Volker> (sample signature key) <key＠key>:
Volker> ;sec::768:16:D514CB72B37D9AF4:1998-08-04:0:::crypt (crypt)
Volker> <crypt＠crypt>:
Volker> ;sec::1024:17:4DBDD3258230A3E0:1998-08-04:0:::dummyy
Volker> <d＠d>: ;ssb::1024:20:549B0E6CBBBB43D1:1998-08-04:0:::
Volker> And this is his regexp for matching:
Volker> (key-regexp
Volker>
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):$"
Volker> )
Volker> I'm using gpg-1.05 compiled under cygwin (passing all
Volker> tests) with (see subject) and I get:
Volker> [712]> gpg --list-secret-keys --no-greeting --batch
Volker> --with-colons /users/vzell/.gnupg/secring.gpg
Volker> -------------------------------
Volker> sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker
Volker> Zell (Ciko) <dr.volker.zell＠oracle.com>:::
Volker> ssb::1024:16:2179761C5E488513:2001-05-18:::::::
Volker> vzell＠VZELL /tmp [713]> gpg --list-secret-keys
Volker> --no-greeting --batch --with-colons "Dr. Volker Zell
Volker> (Ciko) <dr.volker.zell(a)oracle.com>"
Volker> sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker
Volker> Zell (Ciko) <dr.volker.zell＠oracle.com>::scESC:
Volker> ssb::1024:16:2179761C5E488513:2001-05-18::::::e:
Volker> As you can see I get two more : at the end of each
Volker> line. Therefore I have to use the following regexp. But
Volker> then everything works. At least for me.
Volker> (key-regexp
Volker>
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\)[^:]*:[^:]*:[^:]*:$"
Volker> )
Volker> Ciao Volker
--
Barrie J. Bremner OpenPGP public key ID: 5164F553
baz [at] barriebremner.com http://barriebremner.com/
baz /baz/ n.
1. [common] The third metasyntactic variable.
2. interj. A term of mild annoyance.
3. Occasionally appended to foo to produce `foobaz'
-- Jargon File v4.3.0, www.tuxedo.org/jargon
4. Me.
5:16 a.m.
|--==> "VZ" == Volker Zell <Dr.> writes:
VZ> Hi
VZ> I think there is a bug in the regular expression in mc-gpg.el
VZ> which is used in mailcrypt-3.5.5 together with gnupg-1.0.5.
I've put a new mailcrypt package in the 'Pre-Releases' directory that
fixes this.
/ftp.xemacs.org:/pub/xemacs/beta/experimental/packages/mailcrypt-2.08-pkg.tar.gz
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
2:39 p.m.
>>>> "Volker" == Volker Zell <Dr.> writes:
Volker> Hi
Volker> I think there is a bug in the regular expression in mc-gpg.el
Volker> which is used in mailcrypt-3.5.5 together with gnupg-1.0.5.
Volker> This is what Brian Warner gets whith his version of gpg:
Volker> ;31:warner＠zs2-pc4% gpg --list-secret-keys --with-colons --no-greeting
Volker> ;/home/warner/.gnupg/secring.gpg
Volker> ;-------------------------------
Volker> ;sec::1024:17:1FE9CBFDC63B6750:1998-08-04:0:::Brian Warner (temporary GPG
key) <warner(a)lothar.com>:
Volker> ;ssb::1024:20:C68E8DE9F759FBDE:1998-08-04:0:::
Volker> ;sec::768:17:16BD446D567E33CF:1998-08-04:0:::signature (sample signature
key) <key＠key>:
Volker> ;sec::768:16:D514CB72B37D9AF4:1998-08-04:0:::crypt (crypt)
<crypt＠crypt>:
Volker> ;sec::1024:17:4DBDD3258230A3E0:1998-08-04:0:::dummyy <d＠d>:
Volker> ;ssb::1024:20:549B0E6CBBBB43D1:1998-08-04:0:::
Volker> And this is his regexp for matching:
Volker> (key-regexp
Volker>
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):$"
Volker> )
Volker> I'm using gpg-1.05 compiled under cygwin (passing all tests) with (see
subject) and I get:
Volker> [712]> gpg --list-secret-keys --no-greeting --batch --with-colons
Volker> /users/vzell/.gnupg/secring.gpg
Volker> -------------------------------
Volker> sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker Zell (Ciko)
<dr.volker.zell＠oracle.com>:::
Volker> ssb::1024:16:2179761C5E488513:2001-05-18:::::::
Volker> vzell＠VZELL /tmp
Volker> [713]> gpg --list-secret-keys --no-greeting --batch --with-colons
"Dr. Volker Zell (Ciko) <dr.volker.zell(a)oracle.com>"
Volker> sec:u:1024:17:0A8F8157EBCFE3E8:2001-05-18::::Dr. Volker Zell (Ciko)
<dr.volker.zell＠oracle.com>::scESC:
Volker> ssb::1024:16:2179761C5E488513:2001-05-18::::::e:
Volker> As you can see I get two more : at the end of each line. Therefore I have
to use the following
Volker> regexp. But then everything works. At least for me.
Volker> (key-regexp
Volker>
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\)[^:]*:[^:]*:[^:]*:$"
Volker> )
Ooops, that shoud be:
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:$"
Ciao
Volker
7:41 p.m.
Volker> I think there is a bug in the regular expression in
mc-gpg.el
Volker> which is used in mailcrypt-3.5.5 together with gnupg-1.0.5.
Ooops, that shoud be:
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:$"
Actually I went for a conservative route and removed that last field and '$'
altogether. We don't really need those fields for mailcrypt (the new ones are
"Signature class" and "Key capabilities") yet, so it is safer to
ignore them.
The benefit is that is new fields are added in the future, the expression
should continue to work.
I've checked in this change to the mailcrypt CVS repository
(http://mailcrypt.sourceforge.net has a pointer) and will be releasing
mailcrypt-3.5.6 just as soon as I can figure out Len's release procedure (in
particular I don't know how to upload anything to sunsite.. any pointers would
be appreciated). The Debian folks already made a mailcrypt package revision
from the CVS repository.. you're more than welcome to do the same.
thanks,
-Brian
Index: mc-gpg.el
===================================================================
RCS file: /cvsroot/mailcrypt/mailcrypt/mc-gpg.el,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- mc-gpg.el 1999/10/07 05:23:46 1.14
+++ mc-gpg.el 2001/05/06 22:55:26 1.15
＠＠ -3,7 +3,7 ＠＠
;; Patrick LoPresti <patl(a)lcs.mit.edu>
;; 1998 Brian Warner <warner(a)lothar.com>
-;; $Id: mc-gpg.el,v 1.14 1999/10/07 05:23:46 budney Exp $
+;; $Id: mc-gpg.el,v 1.15 2001/05/06 22:55:26 warner Exp $
;;{{{ Licensing
;; This file is intended to be used with GNU Emacs.
＠＠ -319,7 +319,7 ＠＠
(if (string= str "***** CONVENTIONAL *****") nil
(let ((result (cdr-safe (assoc str mc-gpg-key-cache)))
(key-regexp
-
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):$"
+
"^\\(sec\\|pub\\):[^:]*:[^:]*:[^:]*:\\([^:]*\\):[^:]*:[^:]*:[^:]*:[^:]*:\\([^:]*\\):"
)
(obuf (current-buffer))
buffer)
12:31 a.m.
|--==> "BW" == Brian Warner <warner(a)lothar.com> writes:
BW> I've checked in this change to the mailcrypt CVS repository
BW> (http://mailcrypt.sourceforge.net has a pointer) and will be releasing
BW> mailcrypt-3.5.6 just as soon as I can figure out Len's release procedure (in
BW> particular I don't know how to upload anything to sunsite.. any pointers
would
BW> be appreciated).
The last time I uploaded something to sunsite (a year or so ago), it
was simply a matter of uploading the tarball and the lsm to
./incoming. They have some software that parses the lsm and moves the
files to their rightful locations.[1]
BW> The Debian folks already made a mailcrypt package revision
BW> from the CVS repository.. you're more than welcome to do the same.
Yep, I'm one step ahead of you. As soon as I was aware of your fix I
released a new XEmacs mailcrypt package.
Footnotes:
[1] Please note this information is from my less than perfect memory
and is at least 12 months old. So YMMV.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
9:20 a.m.
FYI: I just released mailcrypt-3.5.6 which contains the gnupg-1.0.5 patch
(among some small others). Details on sourceforge at
<http://sourceforge.net/projects/mailcrypt/>
cheers,
-Brian
8376
days inactive
8380
days old
6 comments
4 participants
participants (4)
-
Barrie Bremner -
Brian Warner -
Dr. Volker Zell -
Steve Youngs