Martin Buchholz writes: Perhaps I wasn't clear. The stddef.h file is present, and contains the declaration of ptrdiff_t. The problem is that alloc.c doesn't #include <stddef.h> sirius:~/XEmacs/xemacs-21.0-b57/src> grep -l ptrdiff *c alloc.c gmalloc.c malloc.c sheap.c unexec.c vm-limit.c sirius:~/XEmacs/xemacs-21.0-b57/src> grep stddef `!!` grep stddef `grep -l ptrdiff *c` gmalloc.c:#include <stddef.h> gmalloc.c:#include <stddef.h> sheap.c:#include <stddef.h> vm-limit.c:#include <stddef.h> According to the above greppage, don't alloc.c, malloc.c and unexec.c need sttdef.h too, for ptrdiff_t? As I said, the stddef.h header is provided, it just doesn't seem to be getting #included everywhere it needs to. I "inherited" this Sparc4, and indeed, it was not me but a former colleague who set it up. I will check out the gcc installation and make sure it's the right version, etc.

Georg Nikodym writes: <snip> It's not exactly "pain"[1], it's a very minor glitch. I just added a few "#include <stddef.h>"'s in a few of the source files (alloc.c, malloc.c, and unexec.c) and XEmacs builds and runs just fine[2] Should these #includes just get patched into the source, or should it be taken care of by "configure"? The windowing system in question is the version of CDE that came with Solaris 2.5. It has a /usr/openwin/include/X11/Xlib.h that reads like this: #ifndef X_WCHAR #include <stddef.h> #else /* replace this with #include or typedef appropriate for your system */ typedef unsigned long wchar_t; #endif That is the only occurence of "stddef.h" in Xlib.h. So I suppose I have X_WCHAR getting defined from somewhere else, and that's keeping stddef.h from being indirectly included. But it seems that files that use "ptrdiff_t" should not be counting on some kind of indirect inclusion of stddef.h, they should just go ahead and include it. Footnotes: [1] Real pain is trying to get subprocesses working on Win32! [2] although it's slow as molasses on this SparcStation4, compared to the dual-Pentium system I use most of the time...

cgw> Should these #includes just get patched into the source, or cgw> should it be taken care of by "configure"? Source files that use features should #include the headers that define those features. We already assume an ANSI compiler, which guarantees that <stddef.h> will be provided. cgw> The windowing system in question is the version of CDE that came with cgw> Solaris 2.5. It has a /usr/openwin/include/X11/Xlib.h that reads like cgw> this: cgw> #ifndef X_WCHAR cgw> #include <stddef.h> cgw> #else cgw> /* replace this with #include or typedef appropriate for your system */ cgw> typedef unsigned long wchar_t; cgw> #endif cgw> That is the only occurence of "stddef.h" in Xlib.h. So I suppose I cgw> have X_WCHAR getting defined from somewhere else, and that's keeping cgw> stddef.h from being indirectly included. cgw> But it seems that files that use "ptrdiff_t" should not be counting on cgw> some kind of indirect inclusion of stddef.h, they should just go ahead cgw> and include it. Correct. We are in violent agreement. The patch is trivial, and should really be added to XEmacs 21.0, since it is very safe: (I was probably guilty of adding a use of ptrdiff_t to alloc.c) (malloc.c probably isn't used any more, but it can't hurt to add the #include) Obpatch: 1998-10-08 Martin Buchholz <martin(a)xemacs.org&gt; * src/alloc.c: * src/unexec.c: * src/malloc.c: Add <stddef.h> to get ptrdiff_t declaration --- src/alloc.c.orig Thu Oct 8 23:47:09 1998 +++ src/alloc.c Thu Oct 8 23:47:23 1998 ＠＠ -56,6 +56,8 ＠＠ #include "sysfile.h" #include "window.h" +#include <stddef.h> + #ifdef DOUG_LEA_MALLOC #include <malloc.h> #endif --- src/unexec.c.orig Thu Oct 8 23:47:40 1998 +++ src/unexec.c Thu Oct 8 23:47:57 1998 ＠＠ -190,6 +190,7 ＠＠ # define __STDC_EXTENDED__ 1 # endif +# include <stddef.h> # include <stdlib.h> # include <unistd.h> # include <string.h> --- src/malloc.c.orig Thu Oct 8 23:48:10 1998 +++ src/malloc.c Thu Oct 8 23:48:29 1998 ＠＠ -166,6 +166,8 ＠＠ #endif /* not emacs */ +#include <stddef.h> + /* Define getpagesize () if the system does not. */ #include "getpagesize.h"