>>>>> "Ben" == Ben Wing <ben(a)xemacs.org&gt; writes: Ben> NOTE: This patch has been committed. Ben> See if this fixes the crashes. Neither of my two reasonably certain recipes for delete-window crashes (window manager close box and file dialog cancel) produce cores any more. Lookin' good.... Ben> src/ChangeLog addition: 2003-02-19 Ben Wing <ben(a)xemacs.org&gt; * eval.c (unbind_to_hairy): Don't check_quit() unless we're unbinding a real Lisp `unwind-protect' since check_quit() does lots of weird things and not all callers are prepared for it. * frame.c: * frame.c (delete_frame_internal): Make absolutely sure there is no quit checking while we are in a "critical section" during frame deletion.

Lookin' good....

----- Original Message ----- From: "Vin Shelton" <acs(a)xemacs.org&gt; To: "Stephen J. Turnbull" <stephen(a)xemacs.org&gt; Cc: "Ben Wing" <ben(a)xemacs.org>; <xemacs-beta(a)xemacs.org&gt; Sent: Thursday, February 20, 2003 4:17 PM Subject: Re: [COMMIT] patch for crashes when deleting frames >"Stephen J. Turnbull" <stephen(a)xemacs.org&gt; writes: >>>>>>> "Ben" == Ben Wing <ben(a)xemacs.org&gt; writes: >> >>Ben> NOTE: This patch has been committed. >>Ben> See if this fixes the crashes. >> >>Neither of my two reasonably certain recipes for delete-window >>crashes >>(window manager close box and file dialog cancel) produce cores >>any >>more.  Lookin' good.... >> >>Ben> src/ChangeLog addition: >> >>2003-02-19  Ben Wing  &lt;ben(a)xemacs.org&gt; >> >>* eval.c (unbind_to_hairy): >>Don't check_quit() unless we're unbinding a real Lisp >>`unwind-protect' since check_quit() does lots of weird things and >>not all callers are prepared for it. >>* frame.c: >>* frame.c (delete_frame_internal): >>Make absolutely sure there is no quit checking while we are in a >>"critical section" during frame deletion. >> >> >> > >>Lookin' good.... >Me, too.  Thanks, Ben. you're welcome ... although in fact i created this problem a few months ago. [an age-old trick, no?  create a problem and then be the hero for fixing it? :-]

> >- Vin >

>>>>> "Ben" == Ben Wing <ben(a)666.com&gt; writes: Ben> you're welcome ... although in fact i created this problem a Ben> few months ago. [an age-old trick, no? create a problem and Ben> then be the hero for fixing it? :-] IIRC, you also warned that changes to QUIT processing were likely to cause problems, and to be on the lookout. BTW, I just got a crash in the Help menu (this is up-to-date with all your recent commits). Sorry, I managed to trash the gdb session I was running in, nothing useful left :-( It looks like I was in XlwMenuRedisplay when the crash happened. FWIW, it "feels" like I moved the pointer off the menu onto the root window, and XEmacs immediately crashed.

-- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.