Re: [PATCH] fix for Crash in mapcar1
- First Post
- Replies
- Stats
-
Go to
- ----- 2025 -----
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Martin Buchholz <martin(a)xemacs.org> writes:
ChangeLog:
1999-12-17 Martin Buchholz <martin(a)xemacs.org>
* fns.c (mapcar1): Fix ***THREE*** obscure crashes.
With a changelog matching in obscurity?
How about
1999-12-17 Martin Buchholz <martin(a)xemacs.org>
* fns.c (mapcar1): Allow for user code modifying the list we
are looping over.
* fns.c (mapcar1): Allow for the strings STRING_DATA being
reallocated triggered by user code actions.
+ We avoid these problems by making a copy of the list to be
traversed.
+
+ (We could also use EXTERNAL_LIST_LOOP and GCPRO the tail).
Why not do that? We can also do away with the caller calling Flength
when the results are not needed. Then we would only loop over the list
once and in addition the size of the list we can loop over is not
limited by the stack size limit.
Jan
Martin Buchholz
Friday, 17 December
Fri, 17 Dec
1:17 p.m.
New subject: [PATCH] fix for Crash in mapcar1
>>>> "Jan" == Jan Vroonhof
<vroonhof(a)math.ethz.ch> writes:
Jan> Martin Buchholz <martin(a)xemacs.org> writes:
> ChangeLog:
>
> 1999-12-17 Martin Buchholz <martin(a)xemacs.org>
>
> * fns.c (mapcar1): Fix ***THREE*** obscure crashes.
Jan> With a changelog matching in obscurity?
Jan> How about
Jan> 1999-12-17 Martin Buchholz <martin(a)xemacs.org>
Jan> * fns.c (mapcar1): Allow for user code modifying the list we
Jan> are looping over.
Jan> * fns.c (mapcar1): Allow for the strings STRING_DATA being
Jan> reallocated triggered by user code actions.
> + We avoid these problems by making a copy of the list to be
traversed.
> +
> + (We could also use EXTERNAL_LIST_LOOP and GCPRO the tail).
Jan> Why not do that? We can also do away with the caller calling Flength
Jan> when the results are not needed. Then we would only loop over the list
Jan> once and in addition the size of the list we can loop over is not
Jan> limited by the stack size limit.
It's not obvious to me which implementation is faster.
I actually have plans for optimizing map* in a bigger way. The basic
idea is to avoid repeating computations for each function invocation.
Martin
9240
days inactive
9240
days old
1 comments
2 participants
tags (0)
participants (2)
-
Jan Vroonhof -
Martin Buchholz