SL Baur <steve(a)xemacs.org> writes:
Kyle Jones <kyle_jones(a)wonderworks.com> writes in
xemacs-beta(a)xemacs.org:
> I think the patch introduces a descriptor leak.
Not according to my tests.
I think you are right.
Kyle, a question: if write() is failing, doesn't it mean that the
descriptor is practically dead? Does it really need explicit
close()-ing?
Unless there's an O/S which does leak descriptors, I think the
patch I
posted is good enough.
Yes, but please add a #### that marks it for improvements. I think
code outside lstream.c really shouldn't play with streams flags that
way. There should be clean way to achieve the same effect.
Also, I *would* like close() getting called on that fd eventually, no
matter what.
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Then... his face does a complete change of expression. It goes from
a "Vengeance is mine" expression, to a "What the fuck" blank look.