>>>> "Andy" == Andy Piper
<andy(a)xemacs.org> writes:
Andy> At 11:52 PM 1/2/00 -0800, Martin Buchholz wrote:
>>>>>> "KMH" == Karl M Hegbloom
<karlheg(a)inetarena.com> writes:
>
KMH> I have been having the same problem. I've disabled dialog boxes
for
KMH> now. Clicking the buttons in the dialog does nothing; they press,
KMH> but XEmacs doesn't read it. Closing the dialog via the WM causes
KMH> XEmacs to crash.
>
> This happens to me as well, but only on Linux, where I use xaw, and
> not on Solaris, where I get working Motif dialog boxes. This is with
> gutters turned off. Andy?
Andy> Does this make any difference? It's the only thing that might have changed
Andy> this behaviour recently. Hmm, in fact try taking out the subclass bit
Andy> entirely and see if that makes a difference also.
Andy> Index: lwlib-Xaw.c
Andy> ===================================================================
Andy> RCS file: /usr/CVSroot/XEmacs/xemacs/lwlib/lwlib-Xaw.c,v
Andy> retrieving revision 1.9.2.6
Andy> diff -u -r1.9.2.6 lwlib-Xaw.c
Andy> --- lwlib-Xaw.c 1999/12/21 23:08:57 1.9.2.6
Andy> +++ lwlib-Xaw.c 2000/01/03 10:46:04
Andy> @@ -146,7 +146,8 @@
Andy> }
Andy> #endif /* LWLIB_DIALOGS_ATHENA */
Andy> #ifdef LWLIB_WIDGETS_ATHENA
Andy> - else if (XtIsSubclass (widget, labelWidgetClass))
Andy> + else if (XtIsSubclass (widget, labelWidgetClass)
Andy> + || XtClass (widget) == labelWidgetClass)
Andy> {
Andy> Arg al [1];
Andy> XtSetArg (al [0], XtNlabel, val->value);
This patch did not fix the crash, but your second suggestion did work:
I am committing this emergency fix now because it seems like an
important thing to fix now. Andy, feel free to redo later as you
wish.
ChangeLog:
2000-01-03 Martin Buchholz <martin(a)xemacs.org>
* lwlib-Xaw.c (xaw_update_one_widget): Emergency fix for this crash:
(yes-or-no-p-dialog-box "Yes or No")
Index: lwlib-Xaw.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/lwlib/lwlib-Xaw.c,v
retrieving revision 1.9.2.6
diff -u -w -r1.9.2.6 lwlib-Xaw.c
--- lwlib-Xaw.c 1999/12/21 23:08:57 1.9.2.6
+++ lwlib-Xaw.c 2000/01/04 01:58:44
@@ -146,7 +146,7 @@
}
#endif /* LWLIB_DIALOGS_ATHENA */
#ifdef LWLIB_WIDGETS_ATHENA
- else if (XtIsSubclass (widget, labelWidgetClass))
+ else if (XtClass (widget) == labelWidgetClass)
{
Arg al [1];
XtSetArg (al [0], XtNlabel, val->value);
Martin