Re: [PATCH] moving Open URL menu to browse-url
(I answered to xemacs-patches first, I'm resending my comment here. As
mail-lib maintainer I don't have a problem with accepting this, but I
think the real issue is if the XEmacs core should change, so any insight
on that would be good.)
On Mon, 10 Sep 2001, Björn Torkelsson wrote:
Superseeds my earlier patch to menubar-items.
Moving the "Options->Internet->Open URLs With" to browse-url. I think
it's more logical to have it there than in the core, and it's easier to
update when the package changes.
Patch to menubar-items will follow if/when this patch has been accepted.
(These are generic comments, I haven't really looked at the patch.)
FWIW my feelings are that having XEmacs internal stuff in (supposedly)
externally maintained files (browse-url.el) is less than perfect.
(Synching the file with the external source becomes a pain, someone
need to look over the XEmacs specific and decide that they indeed are
XEmacs specific and that they are still valid even after the other
changes. This review has to be done every time the file is synched.
There are more fun things to do..)
But I wouldn't have anything against putting this in a new file,
e.g. xemacs-url.el, in the mail-lib package, since I agree it may be
easier to maintain this in a package than in the core.
So assuming the patch is good (I didn't look at it, sorry) and that it
doesn't _have_ to be in browse-url.el but just in any package (and I
guess mail-lib would be a suitable place), MHO is to move it into a
mail-lib/xemacs-url.el.
$.2 idea..