Re: VC submenu under Tools
On Saturday 28 February 2009, Rodney Sparapani wrote:
Rodney Sparapani wrote:
> And sure enough, this function does not appear to be defined anywhere,
> although it is called from vc-menu-filter in vc-hooks.el
>
> AHA! SVN does not use locking. So change line 968 of vc-hooks.el to
>
> ((or (eq type 'CVS) (eq type 'SVN))
>
> and then it works for me!
That works, but I guess it is not the most elegant solution. Maybe,
instead of changing 968, you should place the following line before it:
((eq type 'SVN) "Next action on")
That's cleaner, more readable and apparently what is happening if
you had made the other change anyway.
Looks like the XEmacs specific menu code is quite outdated and plain broken in
some cases indeed - it comes from the ages when only CVS, RCS and SCCS were
supported. It's also quite painful to maintain and keep in sync the first
menu label with what actually happens with vc-next-action with various
backends (vc-next-action is what gets called anyway, no matter what the label
is), so I'm inclined to apply the attached patch which is kind of the same
approach as you suggested above, but applied to all backends and simplifies
things quite a bit. Comments?
But, when I do a Show
History, then I get the *vc-change-log* buffer filled with the history
which is good, but then there is an error:
[...]
I think this says that (process-mark p) does not return a valid
marker.
The definition of vc-exec-after is on line 943 of vc.el
and (process-mark p) is on line 962 inside that function.
Oh... and by the way, commenting out that line fixes the bug!!!
Hm, I can't reproduce with XEmacs 21.5.28. Which version of XEmacs do you
have? Replacing the line with
(ignore-errors (goto-char (process-mark p)))
rather than commenting it out could be somewhat better, but that probably
isn't a very good thing to do either - I suppose there's a real issue
somewhere needing a proper fix. Could you try the above out anyway? And of
course, help from anyone with finding/fixing the real problem is much
appreciated.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Attachments:
- vc-simplify-menu.patch (text/x-diff — 2.5 KB)