Re: [Q] Re: [PATCH] all my package fixes, mostly build-related

QUERY Whoa, and thanks, Ben! I must say that this is quite a hunk to review, and will require considerable testing. I don't have time to do that right now, but I'll read the patch, comments below. Any test reports very much welcome. In the future, please split patches so that one patch changes one thing. eg. the "build system patch" would contain only build system changes; changes to eg. apel, edebug, diff-mode and vc-hooks don't really belong in this context, and just get lost. Patches this big cause serious overflows in my review buffer :)

On Sat, 2002-11-30 at 09:40, Ben Wing wrote: > This includes lots and lots of fixes to the build process for packages, as > well as some package-specific changes that may need to be handled > separately. The build process changes are: The executive summary sounds very good to me, in particular this: > (3) The build process is changed so that (a) all autoloads are built first, > before any compilation; (b) identical results occur when you run `make' > from any level; (c) all invocations of XEmacs non-interactively at any > level are controlled by $(BATCH) in Local.rules, which by default > outputs stack traces, ensures that out-of-date .elc files are not > loaded, and shows all files loaded in any circumstances. Ok, then on to the patch and ChangeLog. Note that I've commented only to bits that I have something to ask or comment, others seem to be fine, with the disclaimer that I've only read through this *very* quickly. > Correct usage of texi2html consistent with latest versions. [...] > TEXI2HTML = texi2html > -TEXI2HTML_FLAGS = -split chapter > +# It used to appear: > +# TEXI2HTML_FLAGS = -split chapter > +# But this doesn't exist in texi2html 1.56k, on Cygwin. I don't know if

> +# other way of doing things is an older or newer version. > +TEXI2HTML_FLAGS = -split_chapter I think this should be the other way around, ie. default to "-split chapter" and add note about "-split_chapter". My texi2html version 1.64 (which seems to be the version installed in most modernish Linux distros) has: -split =s split document on section|chapter else no splitting

> mule-packages/latin-unity/ChangeLog addition: [...] > * latin-unity-tables.el (latin-unity-equivalences): > Auto-regenerated. Stephen, any objections? > + (2) To specifically set where the package hierarchies are using > + `configure', use the `--package-path' parameter, as follows: The way I've been hacking on packages is to "make install" with just the default settings and symlink the staging dirs under my ~/.xemacs/ as xemacs-packages and mule-packages. Works for me, maybe at least the possibility of using ~/.xemacs as the place where make install copies files would be good. Ditto for Local.rules.template.

> - $(TEXI2HTML) $(TEXI2HTML_FLAGS) -p $* $< > +# V 1.56k (with Cygwin) does not allow -p flag. Works fine without it. > +# $(TEXI2HTML) $(TEXI2HTML_FLAGS) -p $* $< > + $(TEXI2HTML) $(TEXI2HTML_FLAGS) $< texi2html 1.64 doesn't have -p either, but it has -prefix (which may be the same thing?): -prefix =s use as prefix for output files, instead of <docname> My feeling about the patch is that with the texi2html default "reversed", and all unrelated package changes split out, the package build system changes can go in. Let's take a look at the other changes separately afterwards. But before that, I think we should roll new Sumos out of the way. Additionally, I need a confirmation that you'll be around to help out during the next couple of weeks so that we get things rolling again in case something breaks.

Cheers, -- \/ille Skyttä ville.skytta at iki.fi