Re: Help-char bogosoties [was Re: delete-key-deletes-forward]
Jan Vroonhof wrote:
> Presumably there is some reason why the help-char/help-form
stuff
> needs to be performed in next-event, but I don't know what it is.
Probably to do handle things like C-x r C-h.
However I find its use in the minibuffer map very ugly. There is no
reason read-from-minibuffer couldn't use a localkeymap with a binding
for C-h.
Like this: (N.B. This could probably be used more generally)
One issue that springs to mind is that help-char might not be set to
C-h. Maybe lookup-key could perform the help-char test?
The main advantage of the current help-form/help-char mechanism seems
to be `transparent' help, i.e. (next-event) is unaffected by the use
of help-char. How useful is this exactly?
Running grep on the core elisp only produces three matches:
read-quoted-char
perform-replace
read-from-minibuffer
Jan's patch deals with read-from-minibuffer. I would have thought that
perform-replace could handle help-char itself.
read-quoted-char binds help-char to nil at the same time as binding
help-form, so I'm not sure what purpose this serves. The comment says:
;; Don't let C-h get the help message--only help function keys.
but `C-q f1' just complains about not being able to insert f1.
--
Glynn Clements <glynn(a)sensei.co.uk>