Re: [PATCH COMMIT] mail-lib/mail-extr.el upstream sync

SJ> I think the last version (1.46) should go into the sumo, to be SJ> on the safe side. SY> Putting a new version in Pre-Release, and then the old version SY> in the Sumo will be tricky, but I'll see what I can do. SY> Just for the record, our packages repository is supposed to be SY> a stable tree, please try to do your best to keep it that way. This patch looks downright dubious to me. It introduces a large number of typos in comments, and a lot of really stupid capitalization in the ISO 3166 list (I dunno, maybe those are the official names...). purecopy'ing a defcustom value seems weird (although recent XEmacsen don't have an effective purecopy anyway, because of pdump-related changes). I don't have time to do a thorough review, but these little things make me quite a bit nervous.... -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN My nostalgia for Icon makes me forget about any of the bad things. I don't have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py