On Mon, 2005-01-17 at 19:07 +0900, Stephen J. Turnbull wrote:
APPROVE COMMIT 21.5 RECOMMEND 21.4
Ville, thanks for snuffling this out.
Thank you for the review and the changelog :)
Malcolm, there may be a similar problem in event-gtk.h; I don't
understand GTK well enough to guess. I don't recall such reports for
GTK builds, but they're not as common as Xt builds so that may not
mean much. Ville, would you be able to check whether this occurs with
a GTK build, with and without your patch?
Checked, it occurs on both patched and unpatched GTK build of 21.4.16
here.
event-gtk.h does not seem to exist in 21.4. Anyway, I dug around a bit
and found that in my GTK headers the only place where Xutil.h is
included is <gdk/gdkprivate.h> which is pulled in only through
<gdk/gdkx.h>. Tried adding some semi-random '#include
<X11/keysym.h>'s
before those gdkx.h's in all src/*-gtk.c (with 21.4.16), but that did
not make the problem go away. I don't have time to look into 21.5 at
the moment, sorry.