Re: Can't compile 21.4.5
"Stephen J. Turnbull" wrote:
Recapping as Ben and Nix probably haven't been following the thread:
>>>>> "viteno" == Norbert Koch <nk(a)LF.net> writes:
viteno> After applying xemacs-21.4.4-21.4.5.patch to my existing
viteno> source tree, I can't successfully compile, because of
gcc -c -g -O3 -Wall -Wno-switch -Winline -Wmissing-prototypes
-Wsign-compare -W\
shadow -Wpointer-arith -Demacs -I. -DHAVE_CONFIG_H -I/client/include
-I/usr/X1\
1R6/include window.c
window.c: In function `window_loop':
window.c:2692: invalid operands to binary &&
gmake[1]: *** [window.o] Error 1
viteno> The source reads
struct window *p = ...;
case UNDEDICATE_BUFFER:
{
if ((XBUFFER (p->buffer) == XBUFFER (obj)) && (p->dedicated))
p->dedicated = Qnil;
break;
}
I replied that it works for me.
viteno> Oh well, so it must be connected to the configure options
viteno> (sorry for not sending them in earlier).
You probably should send the whole Installation file with the initial
report.
viteno> Ah, found the culprit. A configure run without
viteno> --use-union-type leads to successfull compilation.
Thanks. Reproduced. Patch:
steve＠tleeps18:/var/tmp/XEmacs/xemacs-21.4.5$ diff -u src/window.c{~,}
--- src/window.c~ Tue Oct 23 17:35:39 2001
+++ src/window.c Wed Oct 24 10:36:29 2001
＠＠ -2689,7 +2689,8 ＠＠
case UNDEDICATE_BUFFER:
{
- if ((XBUFFER (p->buffer) == XBUFFER (obj)) &&
(p->dedicated))
+ if ((XBUFFER (p->buffer) == XBUFFER (obj))
+ && !NILP (p->dedicated))
p->dedicated = Qnil;
break;
}
Ben, is the fix correct?
yup.
Nix, if we're going to set to nil anyway,
why is the !NILP needed?
it's not.
also, stylistically it's better usually to say EQ (p->buffer, obj). [i do see
that the same idiom occurs elsewhere in the code. all should be changed.]
viteno> Still it's bug, IMHO. Should I file a report?
You already did.
Bug reports have been redirected to xemacs-beta anyway, as this is
where the developers are most likely to see them. And we lost our bug
database service anyway, it was hosted on cvs.xemacs.org.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.