Current miscompiled macro list

I just committed some changes to the two AWK scripts that find miscompiled macros. These changes make the scripts slightly more accurate, and now output the type of definition (defmacro, defsubst, etc.) to make it easier to pick out the critical ones. The current list of miscompiled macros is: message-y-or-n-p (defmacro) Definition: xemacs-packages/gnus/lisp/message.el Miscompile: xemacs-packages/gnus/lisp/gnus.el x-color-defined-p (defmacro) Definition: xemacs-packages/perl-modes/cperl-mode.el Miscompile: xemacs-packages/zenirc/src/zenirc-color.el combine-after-change-calls (defmacro) Definition: xemacs-packages/prog-modes/diff-mode.el Miscompile: xemacs-packages/mmm-mode/mmm-cmds.el erc-log (defmacro) Definition: xemacs-packages/erc/erc.el Miscompile: xemacs-packages/erc/erc-members.el with-erc-channel-buffer (defmacro) Definition: xemacs-packages/erc/erc.el Miscompile: xemacs-packages/erc/erc-members.el This does not include the miscompiled macros in liece and mailcrypt that are patched here: http://list-archive.xemacs.org/xemacs-patches/200311/msg00134.html I am still awaiting approval of those two parts of that patch. Of the list above, the first, third, fourth, and fifth look legitimate (i.e., somebody really needs to fix them). The second item, x-color-defined-p, is not really a problem because it is in a GNU Emacs-only branch of a conditional. The third item, combine-after-change-calls, is an Emacs optimization, so we can define it to something trivial ... but it does need to be defined to something. Would anybody object to a patch to the zenirc Makefile to make XEmacs define "(defmacro x-color-defined-p (color) t)"? That would get rid of the only false positive (Mats, I was wrong; there is one, not two), and then Mats could alter the smoketest so that the appearance of (defmacro.*) in the output of find-macro-err.awk indicates a failure to compile the packages correctly. -- Jerry James http://www.ittc.ku.edu/~james/