Re: make Extbyte be signed
Martin Buchholz wrote:
>>>>> "Ben" == Ben Wing <ben(a)666.com> writes:
Ben> So, I'd like to make Extbyte be signed. This is actually an
Ben> extremely small patch, but with potentially big ramifications, so
Again, chars can be signed or unsigned on any operating system.
Because I am insane, I occasionally do (from my build script):
# Random crash generator - Variety is the spice of life!
# Don't do this when optimizing for benchmarking consistency.
Cflags (rand() > .5 ? '-fsigned-char' : '-funsigned-char')
if $compiler_usage =~ /-fsigned-char/;
Ben> I'd like to do it after Martin puts out his next
Ben> beta. [Martin???]
I can't put out the next beta because the release criteria are not yet
met. Ben, please fix all the C++ compile errors you recently
introduced, and please try to fix the insdel.c crash that you get from
`make check'. Y'all do run `make check' religiously, right?
you could just check in yoshiki's patch, which never made it in. this will fix
things.
Of course, the compile errors are typically extbyte/char conversion
problems, so maybe you want to commit the extbyte typedef change as
part of the solution?
yup. i'd have to make a whole bunch of changes, and then just undo them as soon
as i put in the Extbyte change.
since you're the only one compiling under c++, how about you let this slide this
one time?
Testing /project/xemacs/ws/dev/tests/automated/lisp-tests.el...Fatal error: assertion
failed, file /project/xemacs/ws/dev/src/insdel.c, line 1122, ( x) >= BI_BUF_BEG (buf)
&& x <= BI_BUF_Z (buf)
(just build with error-checking to get this)
Martin
--
Ben
In order to save my hands, I am cutting back on my mail. I also write
as succinctly as possible -- please don't be offended. If you send me
mail, you _will_ get a response, but please be patient, especially for
XEmacs-related mail. If you need an immediate response and it is not
apparent in your message, please say so. Thanks for your understanding.
See also http://www.666.com/ben/chronic-pain/