Latest "review-then-commit" patch, delete-frame crashes

Ben> this includes a few updates to the last patch, mostly fixes Ben> for further compile warnings and errors discovered. Now building. By the way, patch failed to apply again. That's three in 24 hours, Ben, is your mailer OK? (The two I saw I also tried against clean checkouts, I don't think it's a problem here, unless Gnus has gone crazy.) Last night it was 3 hunks in src/Makefile.in.in, today it was the near-complete removal of lisp/mule/mule-msw-init.el (thank god for trivial failures). (The third was Ville's report) I'm going to bed---aside from the patch failure, I also had to restart XEmacs a half-dozen times (mostly making the same mistakes repeatedly, tired, tired, hate faculty meetings, hate, hate, hatehatehate...) ups, build finished, success, sending build-report under separate cover. Similar crashes to the ones I saw have been reported, croaking in delete-frame. Mine are closer to those reported by Royer (ie, x_any_window_to_frame is in the backtrace). I wonder if Giacomo Boffi's are different, since they don't make it down to x_any_window_to_frame. My crashes seem to be related to mouse pointer not in frame (quitting ediff, dialogs, and closing using a window manager kill button on frame decoration). The "Missing charsets" message you see is harmless (AFAIK); it's due to a UTF-8 locale that I forgot to suppress. Royer's report: <a href="http://list-archive.xemacs.org/xemacs-beta/200302/msg00226.htm... Pine.OSX.4.52.0302131311340.13280(a)teraqny.sevanohynk.bet </a> Giacomo Boffi's report (also follow thread, more backtraces in a followup): <15955.20040.168088.362968(a)boffi95.stru.polimi.it&gt; (xemacs-beta, too new to have an URL yet) Also see Sean McLennan's report (he found an incorrect (?) patch to avoid the crash): <a href="http://list-archive.xemacs.org/xemacs-beta/200302/msg00291.htm... m37kby187k.fsf(a)fillmore.seanm.ca </a> Earliest report seems to be this one from Thomas Kosch: <a href="http://list-archive.xemacs.org/xemacs-beta/200301/msg00628.htm... microsoft-free.m3ptqisevc.fsf(a)grisu.schuckeduster.org </a> o-yasumi-nasai uname -a: Linux tleepslib 2.4.20 #5 Mon Jan 6 19:31:42 JST 2003 i686 unknown unknown GNU/Linux /playpen/Projects/XEmacs/21.5/configure '--with-mule' '--with-xim=xlib' '--with-xfs' '--with-widgets=athena' '--with-athena=3d' '--with-dialogs=athena' '--with-sound=noesd' '--external-widget' '--with-modules' '--debug' '--error-checking=all' XEmacs 21.5-b11 "cabbage" (+CVS-20030218) configured for `i686-pc-linux'. Compilation / Installation: Source code location: /playpen/Projects/XEmacs/21.5 Installation prefix: /usr/local Operating system description file: `s/linux.h' Machine description file: `m/intel386.h' Compiler: gcc -Wall -Wno-switch -Winline -Wmissing-prototypes -Wsign-compare -Wundef -Wstrict-prototypes -Wpacked -Wshadow -Wmissing-declarations -g -O3 Relocating allocator for buffers: no GNU version of malloc: yes - Using Doug Lea's new malloc from the GNU C Library. Window System: Compiling in support for the X window system: - X Windows headers location: /usr/X11R6/include - X Windows libraries location: /usr/X11R6/lib - Handling WM_COMMAND properly. Compiling in support for the Athena widget set: - Athena headers location: X11/Xaw3d - Athena library to link: Xaw3d Using Lucid menubars. Using Lucid scrollbars. Using Athena dialog boxes. Using Athena native widgets. TTY: Compiling in support for ncurses. Compiling in support for GPM (General Purpose Mouse). Images: Compiling in support for GIF images (builtin). Compiling in support for XPM images. Compiling in support for PNG images. Compiling in support for JPEG images. Compiling in support for TIFF images. Compiling in support for X-Face message headers. Sound: Compiling in support for sound (native). Compiling in support for NAS (network audio system). Databases: Compiling in support for Berkeley database. Compiling in support for PostgreSQL. - Using PostgreSQL header file: postgresql/libpq-fe.h - Using PostgreSQL V7 bindings. Internationalization: Compiling in support for Mule (multi-lingual Emacs). Compiling in support for XIM (X11R5+ I18N input method). - Using raw Xlib to provide XIM support. - Using XFontSet to provide bilingual menubar. Compiling in support for Canna on Mule. Compiling in support for the WNN input method on Mule. Mail: Compiling in support for "dot-locking" mail spool file locking method. Other Features: Inhibiting IPv6 canonicalization at startup. Compiling in support for dynamic shared object modules. Using the new portable dumper. Compiling in support for extra debugging code. WARNING: --------------------------------------------------------- WARNING: Compiling in support for runtime error checking. WARNING: XEmacs will run noticeably more slowly as a result. WARNING: Error checking is on by default for XEmacs beta releases. WARNING: --------------------------------------------------------- (gdb) run Starting program: /playpen/Projects/XEmacs/Builds/21.5/src/xemacs Warning: Missing charsets in String to FontSet conversion Program received signal SIGSEGV, Segmentation fault. 0x082f2d84 in x_any_window_to_frame (d=0x865bf28, wdesc=18874752) at /playpen/Projects/XEmacs/21.5/src/frame-impl.h:218 218 { (gdb) cont Continuing. Fatal error (11). Your files have been auto-saved. Use `M-x recover-session' to recover them. Your version of XEmacs was distributed with a PROBLEMS file that may describe your crash, and with luck a workaround. Please check it first, but do report the crash anyway. Please report this bug by invoking M-x report-emacs-bug, or by selecting `Send Bug Report' from the Help menu. If that won't work, send ordinary email to `crashes(a)xemacs.org&#39;. *MAKE SURE* to include this entire output from this crash, especially including the Lisp backtrace, as well as the XEmacs configuration from M-x describe-installation (or equivalently, the file `Installation' in the top of the build tree). *Please* try *hard* to obtain a C stack backtrace; without it, we are unlikely to be able to analyze the problem. Locate the core file produced as a result of this crash (often called `core' or `core.<process-id>', and located in the directory in which you started XEmacs or your home directory), and type gdb /playpen/Projects/XEmacs/Builds/21.5/src/xemacs core then type `where' at the debugger prompt. No GDB on your system? You may have DBX, or XDB, or SDB. (Ask your system administrator if you need help.) If no core file was produced, enable them (often with `ulimit -c unlimited') in case of future recurrance of the crash. Lisp backtrace follows: # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) #<subr delete-frame (interactive)>() # bind (command-debug-status) call-interactively(delete-frame) (dispatch-event "[internal]") # (condition-case ... . error) # (catch top-level ...) Program received signal SIGSEGV, Segmentation fault. 0x4043fa51 in kill () from /lib/libc.so.6 #0 0x082f2d84 in x_any_window_to_frame (d=0x865bf28, wdesc=18874755) at /playpen/Projects/XEmacs/21.5/src/frame-impl.h:218 #1 0x082eeeca in x_event_to_emacs_event (x_event=0xbffff350, emacs_event=0x8a924c0) at /playpen/Projects/XEmacs/21.5/src/event-Xt.c:1520 #2 0x082ec093 in emacs_Xt_event_handler (wid=0x86dd4c8, closure=0x0, event=0xbffff350, continue_to_dispatch=0xbffff25f "\001%G��%＠e\b%G�%＠{\231\b") at /playpen/Projects/XEmacs/21.5/src/events.h:880 #3 0x401c25d9 in XtDispatchEventToWidget () from /usr/X11R6/lib/libXt.so.6 #4 0x401c2e28 in _XtOnGrabList () from /usr/X11R6/lib/libXt.so.6 #5 0x401c311a in XtDispatchEvent () from /usr/X11R6/lib/libXt.so.6 #6 0x401cde5c in XtAppProcessEvent () from /usr/X11R6/lib/libXt.so.6 #7 0x082f168e in emacs_Xt_drain_queue () at /playpen/Projects/XEmacs/21.5/src/event-Xt.c:2924 #8 0x08110baa in event_stream_quit_p () at /playpen/Projects/XEmacs/21.5/src/event-stream.c:1886 #9 0x0829b5ea in check_quit () at /playpen/Projects/XEmacs/21.5/src/signal.c:987 #10 0x080f8b16 in unbind_to_hairy (count=1) at /playpen/Projects/XEmacs/21.5/src/eval.c:5940 #11 0x080f8ae9 in unbind_to_1 (count=1, value=1079444816) at /playpen/Projects/XEmacs/21.5/src/eval.c:5923 #12 0x080edff8 in elisp_maphash ( function=0x81a3cd0 <check_instance_cache_mapper>, hash_table=145476232, extra_arg=0x89f3ad0) at /playpen/Projects/XEmacs/21.5/src/elhash.c:1400 #13 0x0819dfc4 in check_window_subwindow_cache (w=0x89f3ad0) at /playpen/Projects/XEmacs/21.5/src/glyphs.c:663 #14 0x083266a4 in mark_window_as_deleted (w=0x89f3ad0) at /playpen/Projects/XEmacs/21.5/src/window.c:2082 #15 0x0831f4e5 in delete_all_subwindows (w=0x94844c8) at /playpen/Projects/XEmacs/21.5/src/window.h:37 #16 0x081894a2 in delete_frame_internal (f=0x89ce7e0, force=155731144, called_from_delete_device=0, from_io_error=0) at /playpen/Projects/XEmacs/21.5/src/window.h:37 #17 0x0818e7d4 in Fdelete_frame (frame=0, force=1079443280) at /playpen/Projects/XEmacs/21.5/src/frame.c:1859 #18 0x080f65e1 in Feval (form=155113976) at /playpen/Projects/XEmacs/21.5/src/eval.c:3595 #19 0x080f6dcb in Ffuncall (nargs=2, args=0x1) at /playpen/Projects/XEmacs/21.5/src/eval.c:3839 #20 0x080f7ae4 in call1 (fn=1079444816, arg0=1079444816) at /playpen/Projects/XEmacs/21.5/src/eval.c:4483 #21 0x081131c8 in execute_command_event (command_builder=0x865bef0, event=145390780) at /playpen/Projects/XEmacs/21.5/src/event-stream.c:799 #22 0x0810d694 in Fdispatch_event (event=145390780) at /playpen/Projects/XEmacs/21.5/src/event-stream.c:4571 #23 0x080be826 in Fcommand_loop_1 () at /playpen/Projects/XEmacs/21.5/src/cmdloop.c:569 #24 0x080f3bfb in condition_case_1 (handlers=1079442632, bfun=0x80bed1c <command_loop_1>, barg=1079444816, hfun=0x80bed60 <cmd_error>, harg=1079444816) at /playpen/Projects/XEmacs/21.5/src/eval.c:1888 #25 0x080bef34 in command_loop_2 (dummy=1079444816) at /playpen/Projects/XEmacs/21.5/src/cmdloop.c:251 #26 0x080f3ab5 in internal_catch (tag=1079444816, func=0x80beeec <command_loop_2>, arg=1079444816, threw=0x0, thrown_tag=0x0) at /playpen/Projects/XEmacs/21.5/src/eval.c:1500 #27 0x080beaab in initial_command_loop (load_me=1079444816) at /playpen/Projects/XEmacs/21.5/src/cmdloop.c:300 #28 0x080f096b in xemacs_21_5_b11_i686_pc_linux (argc=1, argv=0xbffffd14, envp=0xbffffd1c, restart=0) at /playpen/Projects/XEmacs/21.5/src/emacs.c:2400 #29 0x080f13e2 in main (argc=1079444816, argv=0x40570550, envp=0x40570550) at /playpen/Projects/XEmacs/21.5/src/emacs.c:2892 #30 0x4042ea51 in __libc_start_main () from /lib/libc.so.6 (gdb) -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.