Re: [ANN] ViaVoice module, version 0.5.0

JJ> Since this is my first time writing C for XEmacs, I would appreciate any JJ> comments on style. This looks like very well written software, better than the average quality of XEmacs. Some comments... DEFUN ("sm-word-value", Fsm_word_value, 1, 1, 0, /* Retrieve the value from WORD, an sm-word structure. The interpretation of this value depends on `(sm-word-type WORD)'. */ The first line of the DOCSTRING is supposed to be an independent sentence (for apropos). Like this: Retrieve the value from WORD, an sm-word structure. The interpretation of this value depends on `(sm-word-type WORD)'. /* Make sure this session identifier is good, and assign it */ #define CHECK_SESSION_NUMBER(s,ss) do { \ CHECK_INT (s); \ ss = XREALINT (s); \ if (ss < 0 || ss >= SM_MAX_SESSIONS) \ signal_error (Qinvalid_argument, s); \ } while (0) /* And the Lord said: Thou shalt use the `c-backslash-region' command to make macros prettier. */ DEFUN ("vv-word-to-events", Fvv_word_to_events, 2, 2, 0, /* This callback for recognized words turns the word into a series of key events, which are fed into the normal XEmacs event handlers. This is the callback that will allow dictation and voice command-and-control in XEmacs. REPLY is the reply message from the ViaVoice engine. DATA is unused. To use this callback, evaluate (sm-add-callback smn-recognized-word-callback 'vv-word-to-events) */ (reply, data /* unused */)) If you have a `(' in column 1, precede it with a `\' in order not to confuse cc-mode. E.g. go down a line and hit TAB.