Re: smtpmail.el fix for AUTH LOGIN (PR#1687)

Full_Name: Don Pellegrino OS: Windows 2000 Pro Version: 21.4 Solid Vapor mule: no severity: Aggravating Submission from: (NULL) (151.197.120.90) The current version of smtpmail.el in the mail-lib package (mail-lib-1.37-pkg.tar.gz) only supports the SMTP AUTH mechanism "cram-md5". There is code in the file to handle the SMTP AUTH "login" mechanism but due to bug/typo the login mechanism is never used. Below are pasted the ediff of the changes I made and the original file. AUTH LOGIN is now working fine for me. On another note, perhaps there is an easier way to implemented all of the AUTH SASL mechanisms by tying some sort of SASL package with the SMTP AUTH function? Let me know if you need more info on this bug. *** C:\DOCUME~1\don\LOCALS~1\Temp\smtpmail.el Wed May 16 15:09:58 2001 --- C:\DOCUME~1\don\LOCALS~1\Temp\smtpmail.elIUAeow Wed May 16 15:09:58 2001 *************** *** 185,191 **** (defvar smtpmail-queue-index (concat smtpmail-queue-dir smtpmail-queue-index-file)) ! (defconst smtpmail-auth-supported '(cram-md5) "List of supported SMTP AUTH mechanisms.") ;;; --- 185,191 ---- (defvar smtpmail-queue-index (concat smtpmail-queue-dir smtpmail-queue-index-file)) ! (defconst smtpmail-auth-supported '(cram-md5 login) "List of supported SMTP AUTH mechanisms.") ;;; *************** *** 510,516 **** (not (integerp (car response-code))) (>= (car response-code) 400)) (throw 'done nil))))) ! ((member 'auth=login supported-extensions) (smtpmail-send-command process "AUTH LOGIN") (if (or (null (car (setq response-code (smtpmail-read-response process)))) (not (integerp (car response-code))) --- 510,518 ---- (not (integerp (car response-code))) (>= (car response-code) 400)) (throw 'done nil))))) ! ( ! ;(member 'auth=login supported-extensions) ! (eq mech 'login) (smtpmail-send-command process "AUTH LOGIN") (if (or (null (car (setq response-code (smtpmail-read-response process)))) (not (integerp (car response-code)))