Re: (insert 8000) crashes XEmacs 21.2.16
Yoshiki Hayashi <t90553(a)m.ecc.u-tokyo.ac.jp> writes:
Ben Wing <ben(a)666.com> writes:
> When I wrote all this code, I made a conscious decision, for compatibility
> reasons, to allow integers wherever characters are allowed. If we're going to
> change this, (a) we should think carefully about what this means, and (b) we
> should fix this all throughout XEmacs.
I am confused. Your plan and Kyles' plan below can't coexist.
Which means that they disagree on this one. I agree with Ben here,
for two reasons:
2. If we are to disallow inserting integers, we should do it with some
more care about where integers can popup. Believe me, it's in many
many places (as both Ben and Kyle know);
1. The patch as it stands doesn't really fix the source of the
problem. If (insert 8000) signals an error, but (insert (int-char
8000)) crashes XEmacs, then something is wrong.
It's easy to fix and here is the patch. I'll send this to
xemacs-patches if this is needed after discussions are over.
[...]
This patch looks good to me, but I'll wait for Ben's judgement, as he
is the one who really understands that code.