Re: [Q] Re: [AC21.4R21.5] Guard make-search-dialog call in menubar-items.el

QUERY >>>>> "Vin" == Vin Shelton <acs(a)xemacs.org&gt; writes: Vin> I will be committing this to 21.4. Let me know if you want me to Vin> apply this to 21.5. Vin> - Vin Vin> lisp/ChangeLog addition: Vin> 2003-12-04 Vin Shelton <acs(a)xemacs.org&gt; Vin> * menubar-items.el (menu-item-search): New. Vin> * menubar-items.el (default-menubar): Only bring up search dialog Vin> box if the feature is available. Vin> 21.4 source patch: Vin> Diff command: cvs -q diff -u Vin> Files affected: lisp/menubar-items.el Vin> Index: lisp/menubar-items.el Vin> =================================================================== Vin> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/menubar-items.el,v Vin> retrieving revision 1.19.2.8 Vin> diff -u -u -r1.19.2.8 menubar-items.el Vin> --- lisp/menubar-items.el 2003/01/07 03:57:11 1.19.2.8 Vin> +++ lisp/menubar-items.el 2003/12/04 16:16:38 Vin> ＠＠ -128,6 +128,13 ＠＠ Vin> ""))) Vin> (t ""))) Vin> +(defun menu-item-search () Vin> + "Bring up a search dialog if possible, else do interactive search" Vin> + (interactive) Vin> + (if (featurep 'dialog) Hi Vin, shouldn't the higher-level (if (should-use-dialog-box-p) be used o above line instead? Else we will defeat force-dialog-box-use and use-dialog-box