Re: Audits and vetos [was: Issues outstanding, redux (summary)]

Stephen> o Audit for synchs and feature additions that don't work Stephen> with Mule (eg, people have patched/intend to patch Stephen> smtpmail and ps-print in ways that cause data loss and Stephen> other wastage under Mule) APA> smtpmail: APA> Steve, please don't limit yourself to vetoing and auditing. Stephen> I don't. My message that you cited still has 3.5 days Stephen> left in my deadline, OK? Getting this right is not an I didn't mean to pressurize you, but your broad statement above made people contributing to smtpmail and ps-print* really look bad. Stephen> easy thing; mail is a bitch, and I'm not a mail Stephen> specialist. Nor is Mule trivial, at least I know Stephen> something about that. And I never heard of smtpmail I sure appreciate that. Stephen> until Simon's patch the other day, let alone looked at Stephen> it. Testing it will be time-consuming, as I have never Stephen> explicitly specified a mailer backend for xemacs before; Stephen> I'll have to figure out how to do that. Not to mention Stephen> coming up with a few test cases. APA> I have offered to patch smtpmail as per your recommendation. Stephen> Adrian, I don't know when the current version of smtpmail Stephen> was checked in or by whom, but it is BROKEN. Not after OK. That statement rehabilitates Simon. Many of your statements leave a lot room for interpretation. Stephen> Simon's patch. The one currently being distributed in Stephen> mail-lib. Stephen> Any attempt to send non-ISO-8859-1 characters by smtpmail Stephen> as it stands will turn every single one of them into a Stephen> tilde, to the best of my knowledge. The fact that we Stephen> haven't had any bug reports about it leads me to hope Stephen> that I've analyzed it incorrectly. Still I am unwilling Stephen> to approve a patch until I have reason to believe it Stephen> doesn't make things worse than they already are. Adding Fair enough. It's good to hear you still plan to fix this. Stephen> features that would attract users to the package is Stephen> making things worse, unless there are some safeguards put Stephen> in place to keep it from doing harm. I completely agree. Stephen> The patch you proposed to ps-print would do a similar Stephen> thing for printing from Mule; at least ps-print would Stephen> merely waste paper. Which one? See what I mean? Please provide a URL or Message-ID. I haven't mailed in a ps-print patch recently, AFAIK. Stephen> The point is not any particular patch; it's just random Stephen> luck that the two cases I know of right now are these Stephen> two. Stephen> But surely there are more of these in the code base by Stephen> now. I don't review every patch for Mule implications; Stephen> maybe I should have, and I'll start trying to do more, Stephen> but EVERYTHING on xemacs-patches is a LOT of traffic. Stephen> Auditing for this kind of thing is necessary for a Stephen> release. People will be VERY angry if they lose mail Stephen> because of this. No question about that. APA> ps-print-nomule: APA> I almost have a patch for ps-print-nomule ready. I am not APA> qualified to work in the mule version. Stephen> And it will be reviewed for Mule implications even though Stephen> it is nominally "non-Mule," and it will be vetoed if it Stephen> causes problems if invoked from a Mule XEmacs. OK. Perhaps you can make recommendations how to avoid using ps-print-nomule under Mule XEmacs. Stephen> At which point if other reviewers feel that the benefits Stephen> of the patch to non-Mule users outweigh the problems for Stephen> Mule, the veto will be overridden. That's the way the Stephen> process is supposed to work. Yes. I'll give it a shot. Best regards, Adrian Stephen> -- Stephen> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Stephen> Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091 Stephen> _________________ _________________ _________________ _________________ Stephen> What are those straight lines for? "XEmacs rules." -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org