Re: make-charset doesn't handle 'short-name' properly
Yoshiaki Kasahara <kasahara(a)nc.kyushu-u.ac.jp> writes:
Excuse me, would someone please respond ? Is this patch pointless??
Sorry, I've been away for a while.
> Index: mule-charset.c
> ===================================================================
> RCS file: /usr/CVSroot/XEmacs/xemacs/src/mule-charset.c,v
> retrieving revision 1.19
> diff -u -r1.19 mule-charset.c
> --- mule-charset.c 2001/04/12 18:24:03 1.19
> +++ mule-charset.c 2001/04/25 08:03:28
> ＠＠ -693,7 +693,7 ＠＠
> short_name = value;
> }
>
> - if (EQ (keyword, Qlong_name))
> + else if (EQ (keyword, Qlong_name))
> {
> CHECK_STRING (value);
> long_name = value;
>
This patch is correct. Please send it to xemacs-patches
with ChangeLog entry. However, I think XEmacs handles
sort-name properly since both (EQ (keyword, Qshort_name))
and (EQ (keyword, Qlong_name)) will never be true at the
same time. It's just a little bit of performance loss if a
compiler is not smart enough. But it's definitely a good
thing to improve the readability of source code.
--
Yoshiki Hayashi