Re: XEmacs patches to custom.el
s/xemacs-review/xemacs-beta/
Per Abrahamsen <abraham(a)dina.kvl.dk> writes:
Hrvoje Niksic <hniksic(a)iskon.hr> writes:
> Per Abrahamsen <abraham(a)dina.kvl.dk> writes:
>
> > (custom-declare-variable): Don't use `push'.
> [...]
> > (custom-declare-group): Use `setq' instead of `pop'.
>
> Why?
To avoid loading the cl runtime in Emacs 21 (I'm not going to take
that fight), however Dave Love mentioned on the emacs-custom list
that pop and push are now in subr.el, so the change is unnecessary.
OK. Most of the time, if you maintain the code, you get to make the
rules. In XEmacs, it is perfectly fine to use the CL runtime. But if
keeping the versions as close as possible makes your life easier, feel
free to de-CL-ize the source.
> XEmacs does not have a problem with backquotes, and this change
> apparently makes the code less readable.
I agree, and the issue might be void if the file is going to require
cl macros (defun*...) anyway. Before themes custom.el was a small
file which it made sense to put early in the bootstrap sequence.
I'll delay committing until I have heard back from Gerd.
It still makes sense for custom.el to be loaded as early as possible,
so that other files can use its features. I'm not sure how the
bootstrap issues are handled, but Steve Baur (who worked on these
things at the time) apparently solved them, for things seem to work.