Doing "man" makes "find-file" put every file in a new window

This bug report will be sent to the XEmacs Development Team, not to your local site managers!! Please write in English, because the XEmacs maintainers do not have translators to read other languages for them. In XEmacs 21.4 (patch 0) "Solid Vapor" [Lucid] (i686-pc-cygwin) of Tue Apr 17 2001 on SHALOM configured using `configure --with-netinstall --with-x=no --bindir=/usr/local/bin/i686-pc-cygwin' Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I may have mentioned this informally a while ago, but I may never have actually reported it. I find that normally, "find-file-other-window" and "find-file" both work correctly, opening a new file in either the other window or the current window, but in the same frame. When I use the "manual-entry" command, it correctly opens the man page in a separate frame. If I then do "find-file-other-window", it opens up the new file in a separate frame. All subsequence calls to "find-file-other-window" open up new frames. However, if I then do "load-library" and specify "files", the next and subsequent calls to "find-file-other-window" go back to the correct behavior. During this, the behavior of "find-file" does not change, it always opens up a new window in the same window in the same frame. I'm pretty certain this is happening because of the following piece of code in my "$HOME/.xemacs/init.el", which I got off the net at some point, to allow man pages to be put into separate frames: (defadvice manual-entry (around other-frame activate) (letf (((symbol-function 'switch-to-buffer-other-window) (symbol-function 'switch-to-buffer-other-frame))) (let ((Manual-buffer-view-mode 'other-frame)) ad-do-it))) If I understand this correctly, the intent of this advice is, inside the body of the "letf", it will make "switch-to-buffer-other-window" actually do "switch-to-buffer-other-frame", then do the advised function, and then on exit from the "letf", the old behavior is restored. Either I'm misunderstanding something, or "letf" is failing to restore the "PLACEs" to their original value, on exit from the "letf". Recent keystrokes: C-x , C-f C-f i C-d C-e C-a C-a C-x C-s C-p C-p C-p C-p C-SPC C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n ESC w C-x C-g q button1 button1up M-x r e p o r t - x e m TAB BS BS BS e m TAB RET D o i n g SPC " m a n " SPC m a k e s SPC C-g C-h k C-x C-f q M-x r e p o r t - e m TAB RET Recent messages (most recent first): Parsing /home/david.karr/.mailrc... Loading view-less...done Loading view-less... Quit Loading emacsbug...done Loading emacsbug... Entering debugger... Wrote /home/david.karr/docs/log_stat.notes.txt Wrote /home/david.karr/docs/log_stat.notes.txt Quit