>>>> "Robert" == Robert Pluim
<rpluim(a)bigfoot.com> writes:
Robert> So if I read the patch right, doing (require 'ibuffer)
Robert> would be enough to get the keybinding changed?
Urk. Please think carefully about this. Changing keybindings is
always one of the most controversial aspects of patching. In
particular, we've made a point in many cases of trying to ensure that
user-visible changes are never activated by a require (the user
normally does not know that they are require'ing a library). (Cf the
"howcum JPEGs don't enter image-mode in 21.4" thread, etc.)
Are people going to be shocked if something require's ibuffer behind
their backs? I'm sure you think the shock will be pleasant; the point
is some people will not agree.
[This is not opposition to this particular patch, I haven't looked at
it yet.]
(Unofficial) Guide to Keybinding Changes
1. If you change any keybindings, say so in the ChangeLog.
2. Explain in the text why this change is a good thing ("ibuffer has
been blessed..." is probably enough here, what's good for the GNUs
is not always good for the Gnader, but usually).
3. Explain if the principle of no surprise has been violated, and why
this patch complies with the principle of least surprise.
4. Think twice if it seems likely that more than about two carrots
and a rutabaga will be tempted to reach for C-h k to figure out
what's going on. Anything with a spinal cord should get it
immediately. :-)
--
Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.