Re: Info - uniquify incompatibility ...

On Mon, 1 Oct 2001, Volker Franz uttered the following: Well done; I haven't managed to figure it out at all. Good god, is *that* it? No wonder I never managed to debug it :( Likewise. I'm amazed you managed it, actually. This is still not ideal, because the real criterion is `bucffers whose mode is Info-mode'; this will still break people who rename their Info buffers themselves. In the interests of insane generality, and to make it easier to add new exclusion classes to uniquify, might I suggest something like the following (disclaimer: not heavily tested but it seems to stop the problem here)... (btw, is there a better customization type for hooks than `lisp'? I tried to write one and gave up, but then I'm a customize newbie.) 2001-10-05 Nix <nix(a)esperi.demon.co.uk&gt; * uniquify.el (uniquify-ignore-buffers-query-functions): New hook, called to determine buffers not to uniquify. (uniquify-rationalize-file-buffer-names): Use it... (uniquify-ignore-buffers-re): ... reimplement in terms of it. New function. (uniquify-ignore-buffers-mode-re): New variable and function. --- edit-utils/uniquify.el~ Fri Oct 5 21:00:42 2001 +++ edit-utils/uniquify.el Fri Oct 5 22:10:06 2001 ＠＠ -130,6 +130,20 ＠＠ :type '(choice (const :tag "Uniquify all buffers" nil) regexp) :group 'uniquify) +(defcustom uniquify-ignore-buffers-mode-re "^Info-mode$" + "*Regexp matching names of major modes of buffers that should not be uniquified. +For instance, set this to \"^\\\\(Info\\\\)\\\\|\\\\(message\\\\)-mode$\" to avoid +having uniquify rename Info and mail message buffers." + :type '(choice (const :tag "Uniquify all buffers" nil) regexp) + :group 'uniquify) + +(defcustom uniquify-ignore-buffers-query-functions '(uniquify-ignore-buffers-re + uniquify-ignore-buffers-mode-re) + "*Functions to call to determine if a buffer name should not be uniquified. +The functions are called with one argument, the buffer. If any function returns +t, the buffer name is not uniquified." + :group 'uniquify) + (defcustom uniquify-min-dir-content 0 "*Minimum number of directory name components included in buffer name." :type 'integer ＠＠ -202,10 +216,9 ＠＠ (uniquify-buffer-file-name buffer))) (rawname (and bfn (uniquify-file-name-nondirectory bfn))) (deserving (and rawname - (not (and uniquify-ignore-buffers-re - (string-match - uniquify-ignore-buffers-re - (buffer-name buffer)))) + (not (run-hook-with-args-until-success + 'uniquify-ignore-buffers-query-functions + buffer)) (or (not newbuffile) (equal rawname (uniquify-file-name-nondirectory ＠＠ -440,6 +453,24 ＠＠ (remove-hook 'post-command-hook 'delayed-uniquify-rationalize-file-buffer-names)) +(defun uniquify-ignore-buffers-re (buffer) + "Returns t if the BUFFER's name matches `uniquify-ignore-buffers-re'. +Meant to be called from the `uniquify-ignore-buffers-query-functions'." + (and uniquify-ignore-buffers-re + (string-match + uniquify-ignore-buffers-re + (buffer-name buffer)))) + +(defun uniquify-ignore-buffers-mode-re (buffer) + "Returns t if the BUFFER's major mode matches `uniquify-ignore-buffers-mode-re'. +Meant to be called from the `uniquify-ignore-buffers-query-functions'." + (and uniquify-ignore-buffers-mode-re + (string-match + uniquify-ignore-buffers-mode-re + (symbol-name (with-current-buffer buffer + major-mode))))) + + (add-hook 'kill-buffer-hook 'delay-uniquify-rationalize-file-buffer-names) ;;; uniquify.el ends here -- `Upsetting this BOFH was a BAD MOVE.' --- Chris Newport