Re: Bug located in `process-connection-type' (even in 21.1.14) (WAS: Re: [Adrian Aichner <adrian@xemacs.org>] Re: PCL-CVS shows Parser Errors in *cvs* buffer)
Adrian.Aichner(a)t-online.de (Adrian Aichner) writes:
>>>>> "Jarl" == Jarl Friis
<jarl(a)diku.dk> writes:
Jarl> Adrian.Aichner(a)t-online.de (Adrian Aichner) writes:
>> >>>>> "Jarl" == Jarl Friis <jarl(a)diku.dk>
writes:
>>
Jarl> I have made a very small program that demonstrates the
Jarl> location of the bug. Essentially it is setting the variable
Jarl> `process-connection-type' to nil that causes trouble. In the
>>
>> Hi Jarl,
>>
>> thanks for narrowing in on this!
Jarl> Thank *you* for helping and commenting and taking the thread
Jarl> seriously.
>>
>> I am using a slightly modified version which names the process buffers
>> uniquely so I can diff them afterwards.
Jarl> Modified version of what? pcl-cvs? XEmacs C code? net-utils?
Oh, I modified your test case to this:
I see, now I get it. to make it even easier I suggest the following
bug-reproducing code:
,----
| (let (
| (mypassword "PaSsWoRd");;insert a password here
| (default-directory (cvs-expand-dir-name
"~/projects/cvs-sandbox/xemacs-devel/packages"))
| )
| (progn
| (setq process-connection-type nil) ; Use a pipe.
| (kill-buffer (get-buffer-create " *mycvs-tmp-pipe*"))
| (apply 'start-process "mycvs-pipe" (get-buffer-create "
*mycvs-tmp-pipe*") "cvs" '("-f" "status"))
| (setq process-connection-type t) ; Use a pty.
| (kill-buffer (get-buffer-create " *mycvs-tmp-pty*"))
| (apply 'start-process "mycvs-pty" (get-buffer-create "
*mycvs-tmp-pty*") "cvs" '("-f" "status"))
| (process-send-string "mycvs-pty" (concat mypassword "\n"))
| )
| )
`----
To Steve (and other (unix) tester ): If there are "major" differences
in the two buffers, then that demonstrates the bug.
>>
>> Could you please do the same on send in the diffs?
Jarl> I'm not sure I understand what you mean here; "diffs" of
Jarl> what? "do the same" as what?
Diffs between
" *mycvs-tmp-pty*" and " *mycvs-tmp-pipe*".
I see. You should know I am not hooked up by that fast a line
(256kb/s) so doing a cvs status on the 'packages' module takes some
time.
Another thing is that it seem not very reproducible to me on that
module, but Steve had experienced this, Steve would you please do the
bug-demonstration on the 'packages' module?
Jarl> Nevertheless getting this close I probably will
continue
Jarl> until fixed :-) I am competent in unix system C programmer
Jarl> so I guess it's just a question of getting a grip of the
Jarl> XEmacs C code. I may ask the guy who splitted
Jarl> `process-unix.c' Kirill M. Katsnelson <kkm(a)kis.ru>.
Good plan!
If you use vc, try this in process-unix.c:
C-x v g runs the command vc-annotate
OK, cool. I am not sure of what it is, I see a lot of comments and
code snippets (in different colours) in the file with names (probably
authors). Is it such that I can for any line in the code see who
'touch'ed this line last time and when that happend? kind of who to
blaim/contact for the specific part of the code?
>>
>> I'll be skiing for a week starting saturday.
Jarl> Have a good holyday, it's my turn next friday; heading for
Jarl> Val. T. on my snowboard :-DD)
Once I stop falling out of the lifts I'll probably be a snowboard god. :-)
>>
>> I hope somebody will take this up meanwhile.
Jarl> I will continue for some time. Please catch me up on this I
Jarl> tend to forget it, that is I'll be back from snow-land the
Jarl> 10. February.
Have a good one too!
Stay away from skiers!
Were I surf there aren't any skiers anyway, they tend to stick to the
slopes, not the powder and cliff edges where I hang out :-)
Jarl