Re: mouse-2 bug in link.el in dictionary package

Stephen> xemacs-patches removed from cc pending discussion. Volker> It seems that this change is responsible for the Volker> error. Strange enough in the version 1.2.1, which I used, Volker> before dictionary evolved into an Xemacs package, the code Volker> was correct and used to work. Volker> Attached a patch (which at least works for me). Can Volker> anybody confirm this behaviour ? Stephen> Your report indicates that somehow remove-text-properties and/or Stephen> add-text-properties is broken, either the docstrings or the Stephen> implementations. This at least demands a comment in the source to Stephen> indicate that the reversion is to workaround the bug in XEmacs version Stephen> 21.4.3 or so. Stephen> Can you tell what is broken? Oooops, I think my brain was broken. remove-text-properties/add-text-properties are not broken. It's just that button2 is not defined as link-mouse-click when running under xemacs. Here is the right patch: diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~ /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog *** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~ Mon Oct 29 15:27:20 2001 --- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog Mon Oct 29 15:27:20 2001 *************** *** 1,3 **** --- 1,8 ---- + 2001-10-29 Dr. Volker Zell <Dr.Volker.Zell(a)oracle.com&gt; + + * link.el (link-initialize-keymap): Conditionalize on running-xemacs, otherwise + button2 doesn't get defined. + 2001-09-08 Steve Youngs <youngs(a)xemacs.org&gt; * Initial XEmacs Package version. diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~ /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el *** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~ Mon Oct 29 15:20:39 2001 --- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el Mon Oct 29 15:20:39 2001 *************** *** 109,116 **** (defun link-initialize-keymap (keymap) "Defines the necessary bindings inside keymap" ! (define-key keymap [mouse-2] 'link-mouse-click) ! (define-key keymap "\r" 'link-selected) ! (define-key keymap "\M-\r" 'link-selected-all)) (provide 'link) --- 109,121 ---- (defun link-initialize-keymap (keymap) "Defines the necessary bindings inside keymap" ! (if (and (boundp 'running-xemacs) running-xemacs) ! (progn ! (define-key keymap [button2] 'link-mouse-click) ! (define-key keymap [(meta button2)] 'link-mouse-click-all)) ! (define-key keymap [mouse-2] 'link-mouse-click) ! (define-key keymap [M-mouse-2] 'link-mouse-click-all)) ! (define-key keymap [return] 'link-selected) ! (define-key keymap [(meta return)] 'link-selected-all)) (provide 'link)