Re: fc-name-parse called in non-Xft XEmacs
On Thu, Aug 27, 2009 at 3:34 AM, Stephen J. Turnbull<stephen(a)xemacs.org> wrote:
Ow! that's scary ... oh, I see what you mean ("that" ==
patch, not
"that" == change to regexp :-). You had me going for a second.
Oops. Dang ambiguous references.
Mmm. Try just wrapping it:
(ignore-errors (require 'font-mgr)) ; FIXME!
In a --without-xft build you should get some compile warnings that
xft-* functions are not known to be defined, and at runtime if
something falls through to an xft-* function you'll get an undefined
function error for some fc-whatever. Presumably that's an error
anyway if Xft isn't linked, but it might be marginally more confusing.
If that doesn't work, make the change you proposed and flag it
;; #### stephen doesn't like this but it's up to him to do better!
I don't like the direction this is going. The existing rpm includes
an option (unused in Fedora) to build with xft support. The idea is
that once it looks like xft is ready (I'm just waiting for the
"display turds" to go away, actually), I can flip the default from off
to on. The approach we're taking here is going to make that
impossible.
Also, I don't understand how the regexp change helps with the bug
report. Isn't the problem that font-x-font-regexp matches too little?
My predecessor configured Fedora XEmacs to have this in Emacs.ad:
XEmacs*FontSet: -*-helvetica-bold-r-*-*-*-120-*-*-*-*-iso10646-1, \
-*-helvetica-bold-r-*-*-*-120-*-*-*-*-iso8859-*, \
*
I believe that the third spec, the fallback, is what is getting us into trouble:
(string-match font-x-font-regexp "*")
nil
In fact, every single position has to be satisfied. As far as I can
tell, this is the shortest matching string:
(string-match font-x-font-regexp "-*-*-*-*-*--*-*-*-*-*-*-*-*")
0
Shouldn't font-x-font-regexp match strings with some of the positions
left off? That works with xfontsel. Otherwise, perhaps I should
change Emacs.ad to read:
XEmacs*FontSet: -*-helvetica-bold-r-*-*-*-120-*-*-*-*-iso10646-1, \
-*-helvetica-bold-r-*-*-*-120-*-*-*-*-iso8859-*, \
-*-*-*-*-*--*-*-*-*-*-*-*-*
but then the fallback doesn't match "10x20", "fixed", etc.
--
Jerry James
http://www.jamezone.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta