Re: [PATCH] Sync browse-url.el with FSF
Mats Lidell <matsl(a)contactor.se> writes:
(Moved discussion to xemacs-beta)
>>>>> Simon wrote:
Simon> Would it be possible to expand on the ChangeLog, detailing what
Simon> was changed? Perhaps by copying the Emacs ChangeLog entries.
As always this was a bit tricker than expected. It is hard, or maybe
just boring, or both to reverse engineer the ChangeLog. ;-)
'cvs log' on smtpmail.el should help.
But when that is done it is also a matter of style. Should I write
one
ChangeLog entry and in that include the change log entries from the
GNU Emacs ChangeLog like this? Please note that I have kept the dates,
for reference.
I'm not speaking for the XEmacs community, and I'm not aware of any
policy, so this is just my humble opinion: Follow the GNU ChangeLog
syntax (see GNU Coding Standards) as close as possible, unless it is
unreasonable. So the following
2003-11-06 Mats Lidell <matsl(a)xemacs.org>
* browse-url.el: Sync up with GNU Emacs CVS version 1.32 including
the following changes.
(2003-07-31) John Paul Wallington <jpw(a)gnu.org>
* browse-url.el (browse-url-epiphany): Doc fix.
(2003-07-07) Richard M. Stallman <rms(a)gnu.org>
* net/browse-url.el (browse-url-browser-function):
Add alternative for Epiphany.
doesn't really match the ChangeLog syntax, and might be confusing when
using 'grep', or when using a ChangeLog parser (there exists a few
ChangeLog-to-X converters). I'm not sure this is very important, but
anyway.
If consistency within mail-lib matters, here's what I did in an
earlier sync.
2002-09-17 Simon Josefsson <jas(a)extundo.com>
* smtpmail.el: Sync with Emacs CVS (following ChangeLog entries
from Emacs, until 2002-09-16 change).
2002-09-12 Simon Josefsson <jas(a)extundo.com>
* mail/smtpmail.el (smtpmail-send-it): Don't use : in filenames
(for cygwin). Suggested by Andrew Senior <aws at watson.ibm.com>.
Use expand-file-name. Also don't require time-stamp.
2002-09-11 Simon Josefsson <jas(a)extundo.com>
* mail/smtpmail.el (smtpmail-default-smtp-server): Doc fix.
2002-08-30 Simon Josefsson <jas(a)extundo.com>
* mail/smtpmail.el (smtpmail-via-smtp): Delete process buffer
unless s-debug-info is enabled.
2002-05-12 Richard M. Stallman <rms(a)gnu.org>
* mail/smtpmail.el (smtpmail-mail-address): New variable.
(smtpmail-send-it): Bind and use that instead of `mail-address'.
(smtpmail-via-smtp): Likewise.
2002-05-09 Simon Josefsson <jas(a)extundo.com>
* mail/smtpmail.el (smtpmail-send-it): Use user-mail-address from
calling buffer.
2002-05-08 Richard M. Stallman <rms(a)gnu.org>
* mail/smtpmail.el (netrc-machine, netrc-get): Add autoloads.
2002-09-16 Simon Josefsson <jas(a)extundo.com>
* Makefile (REQUIRES): Add ecrypto.