Re: [Adrian Aichner <adrian@xemacs.org>] Re: [Success] XEmacs 21.4.10 "Military Intelligence (RC2 Windows)", i586-pc-win32

sjt> Mike? Andy? Anybody? What's going on here? sjt> Problems with filenames (dired and completion) on Windows are sjt> the main thing now blocking promotion of 21.4 to stable. sjt> Please, let's get this fixed. Adrian, please try this patch to win32_readlink(): Index: src/realpath.c =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/realpath.c,v retrieving revision 1.7.2.2 diff -u -r1.7.2.2 realpath.c --- src/realpath.c 22 Aug 2002 10:58:34 -0000 1.7.2.2 +++ src/realpath.c 7 Oct 2002 05:37:19 -0000 ＠＠ -90,7 +90,7 ＠＠ assert (*name); /* Sort of check we have a valid filename. */ - if (strpbrk (name, "*?|<>\"") || strlen (name) >= MAX_PATH) + if (strpbrk (name, "|<>\"") || strlen (name) >= MAX_PATH) { errno = EIO; return -1; Note: this code has been in XEmacs since 21.2.38, so something else has caused the recent manifestation of bugs. I'm just taking a wild guess at what is triggering the error. I'm pretty sure this code does get called in xrealpath() in both native and Cygwin builds, but in different places. I don't know if this is on the right track to resolve this problem. Somebody is going to have to think about what "check we have a valid filename" means, I have no idea on Windows. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN My nostalgia for Icon makes me forget about any of the bad things. I don't have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py