Re: Ben's Big Patch
Jonathan Harris wrote:
Ben Wing wrote:
> -- general concept of "activate" action subsumes various random
> button2 hacks
That's really, really great. I guess it'll need a updates to a bunch of
packages before Windows users and two-button-mouse X users really see
the benefit.
> mswindows-message
> An MS Windows-specific standard dialog box type similar to
> `question'.
I think that's it's evil to expose the lisp programmer to
system-dependent stuff unless it's absolutely necessary. In this case I
don't think that it is necessary - other toolkits support standard icons
(eg XmMessageBox) and I don't see that the ability to say
'abortretryignore instead of supplying the buttons manually is a big
enough win to introduce a system-dependent API. A more general way of
supporting the use of standard icons would be to extend the 'question
dialog box to accept 'iconexclamation etc. (This would mean that you
couldn't just use MessageBox() to implement this on Windows 'though).
Our Xt implementation could just ignore the icons for the moment.
agreed. in fact, there's no implementation behind the docs; it's still in
`mswindows-message-box'. i put this function in primarily to have a quick way
of popping up a dialog box when xemacs displays an error message on the
popped-up console and then exits, so that the message is visible. it's moved to
the docs of `make-dialog-box' because i'm trying to integrate the various dialog
box hacks. i promise i'll fix this up soon.
The "genericisation" of the printer dialogs are really welcome. But I
don't think you should continue to expose 'print-setup because it's
deprecated ("The Print Setup dialog box should not be used in new
applications") in favour of page-setup. Neither print-setup nor
page-setup have analogues in other toolkits that I'm aware of and since
a Windows-specific print-setup dialog isn't required we shouldn't get
rid of it.
agreed. i just converted code from kirill, and he and i discussed this issue --
he apparently wasn't aware that print setup is deprecated. it'll go away as
soon as we get the windows gui printer interface completely working.
Some minor things I noticed:
- What is the effect of your change to package-get-dependencies?
nothing; that variable was unused.
- Looks like you started to add to the 'transpose-lines
documentation
and forgot to finish.
oops! meant to delete that. thanks for pointing it out.
Jonathan.
--
Jonathan Harris | jhar(a)tardis.ed.ac.uk
London, England | Jonathan.Harris(a)symbian.com
--
Ben
In order to save my hands, I am cutting back on my mail. I also write
as succinctly as possible -- please don't be offended. If you send me
mail, you _will_ get a response, but please be patient, especially for
XEmacs-related mail. If you need an immediate response and it is not
apparent in your message, please say so. Thanks for your understanding.
See also http://www.666.com/ben/chronic-pain/