Re: read-coding-system
Approved, but:
1) You should never combine patches like this. Instead, resubmit the patch that
was not approved, with a comment about this fact. (Which the patch tender --
currently Jan -- ought to have noticed, and done something about.)
2) Try to put some comment into the source whenever you change anything --
e.g.
in case 1:
; exclude blank arguments, which result when the user accepts the default value
in case 2:
change the doc string from
Prompting with string PROMPT.
If the user enters null input, return second argument DEFAULT-CODING-SYSTEM."
to
Prompting with string PROMPT.
If the user enters null input, return second argument DEFAULT-CODING-SYSTEM.
DEFAULT-CODING-SYSTEM can be a string, symbol, or coding-system object."
(and in the process, fix up the code so this is actually true.)
ben
Yoshiki Hayashi wrote:
xemacs -vanilla
C-x RET c RET
Wrong type argument: stringp, iso-2022-8
C-x RET c or universal-coding-system-argument passes
buffer-file-coding-system as a default value to
read-coding-system.
However, read-coding-system only expects string as a default
argument. It should recognize symbol.
Because of CVS, this patch cantains another patch,
http://www.xemacs.org/list-archives/xemacs-patches/9910/msg00047.html
which I've got no reply.
1999-11-16 Yoshiki Hayashi <t90553(a)mail.ecc.u-tokyo.ac.jp>
* minibuf.el (read-coding-system): Accept symbol as
a default-coding-system.
------------------------------------------------------------------------
Index: minibuf.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/lisp/minibuf.el,v
retrieving revision 1.14.2.7
diff -u -r1.14.2.7 minibuf.el
--- minibuf.el 1999/07/22 06:19:44 1.14.2.7
+++ minibuf.el 1999/11/16 06:44:55
＠＠ -327,7 +327,7 ＠＠
(defvar current-minibuffer-contents)
(defvar current-minibuffer-point)
-(defcustom minibuffer-history-minimum-string-length nil
+(defcustom minibuffer-history-minimum-string-length 1
"*If this variable is non-nil, a string will not be added to the
minibuffer history if its length is less than that value."
:type '(choice (const :tag "Any" nil)
＠＠ -2118,7 +2118,9 ＠＠
Prompting with string PROMPT.
If the user enters null input, return second argument DEFAULT-CODING-SYSTEM."
(intern (completing-read prompt obarray 'find-coding-system t nil nil
- default-coding-system)))
+ (if (symbolp default-coding-system)
+ (symbol-name default-coding-system)
+ default-coding-system))))
(defun read-non-nil-coding-system (prompt)
"Read a non-nil coding-system from the minibuffer.
------------------------------------------------------------------------
--
Yoshiki Hayashi