Re: [Q] configure cannot use XawInit.h
Malcolm Purvis <malcolmp(a)xemacs.org> wrote:
QUERY
>>>>> "Jerry" == Jerry James <james(a)xemacs.org> writes:
Jerry> ＠＠ -3967,6 +3972,7 ＠＠
Jerry> #if HAVE_X11_XFUNCPROTO_H
Jerry> #include <X11/Xfuncproto.h>
Jerry> #endif
Jerry> +#include <X11/Intrinsic.h>
Jerry> ])
Thanks for the patch. If I understand autoconf correctly, the #include should
be wrapped in a #if HAVE_X11_INTRINSIC_H (just like for X11/Xfuncproto.h
above) to ensure that only a working Intrinsic.h is used.
If you change the patch to add that then I approve and you can commit.
HAVE_X11_INTRINSIC_H is NOT defined at that point, or ever in fact. On
the other hand, the X11-specific checks ensure that X11/Intrinsic.h can
be found (see line 3173 of configure.ac). Since my changes come after
that, I figured it was okay to include X11/Intrinsic.h absolutely. A
cleaner solution would be to add X11/Intrinsic.h to the default header
files. I don't know how to do that.
--
Jerry James
http://www.ittc.ku.edu/~james/