Re: [C] packages: (require 'overlay) based on (featurep 'xemacs) in goto-addr.el

|--==> "APA" == Adrian Aichner <Adrian.Aichner(a)t-online.de&gt; writes: APA> Is it really necessary to check for (featurep 'xemacs) in the APA> FSF-COMPAT package :-) It is when there's stuff in there that is supposed to run on both XEmacs _and_ GNU/Emacs (goto-addr.el). To my mind, goto-addr.el shouldn't be in fsf-compat. APA> Suggestions and improvements welcome! 1) Move the stuff in fsf-compat that isn't purely a compatibility layer to other packages. 2) Fix any package that depends on fsf-compat. 3) Deprecate fsf-compat. APA> -(unless (fboundp 'overlays-in) APA> +(if (featurep 'xemacs) APA> (require 'overlay)) Just a little nit pick, and there's no need to take it too seriously, but because that `if' only does something when true and nothing when false, it would have been better to write it as a `when'... (when (featurep 'xemacs) (require 'overlay)) -- |---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---| | XEmacs - The only _______ you'll ever need. | | Fill in the blank, yes, it's THAT good! | |------------------------------&lt;sryoungs(a)bigpond.net.au&gt;---|